Epic Fight

Epic Fight

13M Downloads

[Question/Suggestion] RenderPlayerEvent instead of RenderLivingEvent

Cheaterpaul opened this issue ยท 1 comments

commented

You are using the RenderLivingEvent


to replace the players model rendering with yours. My question would be why you don't use the RenderPlayerEvent.Pre that is fired in PlayerRenderer#render and thus is only fired for ClientPlayerEntities.

I am asking because my mod werewolves sometimes replaces the player model with a werewolf renderer that still extends LivingRenderer which causes Epic Fight Mod to cancel the event.

commented

I can't render any of the none player entities with RenderPlayerEvent. It only fired when the player is rendered (both ClientPlayerEntity and RemoteClientPlayerEntity). And RenderLivingEvent also includes RenderPlayerEvent because the PlayererRenderer calls the super method LivingRenderer#render. I don't have any reason to use RenderPlayerEvent.