Slight incompatibility with cosmetic armor reworked (Low Priority)
Coach-mdl opened this issue · 12 comments
Armor equipped in vanity slots does not show up in first person during combat mode. Instead the armor you are wearing in your regular armor slots will render.
Hi. @Coach-mdl maybe you can try to talk about this with the devs of the "cosmetic armor reworked".
#536 this link have a "guide" to help with, just click on "Guideline" in the end.
@gaesyeah They don't use the custom armor but they made their own slot to show a vanity armor. There's no way to recognize the vanity slot for Epic Fight, so it's hard to make compatible.
my mod works by replacing items right before rendering a player and restoring them after. (it uses RenderPlayerEvent.Pre and RenderPlayerEvent.Post)
if your renderer could implement these render events, then compatibility should be able to achieve.
otherwise, if you could provide a special render event similarly for your renderer, I can add compatibility code on my side.
Hi, thanks @zlainsama, but @Yesssssman apparently is only going to come back in October 27th due to personal reasons: #662
Maybe this "bug" can be solved in the near future. Thanks!
@zlainsama Hello, I have a question about how to access your code. Since I'm a beginner at modding, I thought I had to add a dependency to access your code. But in this case, I think that people need to install your mod to run Epic Fight. But If I misunderstood, Is there any way to detect if your mod is installed in runtime? so that it doesn't have to run the code that checks the vanity slot if your mod is not installed.
In Forge, you can use this to check if my mod is installed in runtime: ModList.get().isLoaded("cosmeticarmorreworked")
@zlainsama Ok, thanks! I'll fix this problem after I come back.
@Yesssssman I finally played EpicFight myself, and I know the problem now, I will release a fix in 1.16.5 and 1.17.1 on my end.