Equipment Compare [Forge]

The Fabric version of this mod contains an inject mixin in KeyMapping that is unconditionally cancelled. This is effectively the same as using an overwrite mixin, and is very bad practice:

EquipmentCompare/src/main/java/com/anthonyhilyard/equipmentcompare/mixin/KeyMappingMixin.java

Lines 29 to 44 in 0e1fb08

    
           @Inject(method = "resetMapping", at = @At(value  = "HEAD"), cancellable = true) 
        
           private static void resetMapping(CallbackInfo info) 
        
           { 
        
           	MAP.clear(); 
        
           	Iterator<?> var0 = ALL.values().iterator(); 
        
           	while (var0.hasNext()) 
        
           	{ 
        
           		KeyMapping keyMapping = (KeyMapping)var0.next(); 
        
           		if (!keyMapping.equals(EquipmentCompare.showComparisonTooltip)) 
        
           		{ 
        
           			MAP.put(keyMapping.key, keyMapping); 
        
           		} 
        
           	} 
        
           	info.cancel(); 
        
           }

Doing your mixin this way creates incompatibilities with one of my mods (specifically here (uses Yarn)) and is likely to create issues with other mods that modify keybind behaviour.

If possible, it'd be great if you could switch to a more limited injection scope, potentially making use of the excellent @WrapWithCondition provided by MixinExtras.

Is a fix planned for this? If not, mind if I create a PR for it?

https://modrinth.com/mod/equipment-compare-keybind-fix (Under review 2023-11-13)

	@Inject(method = "resetMapping", at = @At(value = "HEAD"), cancellable = true)
	private static void resetMapping(CallbackInfo info)
	{
	MAP.clear();
	Iterator<?> var0 = ALL.values().iterator();

	while (var0.hasNext())
	{
	KeyMapping keyMapping = (KeyMapping)var0.next();
	if (!keyMapping.equals(EquipmentCompare.showComparisonTooltip))
	{
	MAP.put(keyMapping.key, keyMapping);
	}
	}
	info.cancel();
	}

Share to