Large number of damage particles lagging the server
kang-png opened this issue · 8 comments
Please check any boxes that apply to you and your issue
-
I use a translator application to post this issue.
-
This is a crash. Please upload, Pastebin, Gist or copypaste the whole crash report along with this issue.
-
This is a mod incompatibility. If I do this in vanilla Forge with only Et Futurum Requiem installed, it works normally.
Version number of Et-Futurum-Requiem (IMPORTANT)
Et_Futurum_Requiem-2.4.2
Describe the issue (IMPORTANT)
High damage weapons attacking entities with excessive blood will produce a large number of damage particles, resulting in high latency in the server。Very high ping
Your Et Futurum Requiem version is severely outdated. Please update to 2.4.5 or 2.4.6.
This issue will be closed in 3 days if you do not update
Also you will need to provide steps to reproduce, because damage particles are only handled by the client, they should not be causing server lag. This could be a mod conflict.
Realistically the only way this could even cause any lag is if you do thousands of damage, because the heart is a particle. If that is the case, this will not be fixed. The solution to that is not to use damage indicator particles if you have mobs that have so much health and high damage weapons.
Maybe the number of particles spawned for damage could be capped?
Say, it treats any number of damage >100 as just 100?
I think that may defeatthe purpose of the particles altogether if they generate in a misleading count.
Or, possible feature request, there are special heart sprites that represent 10, 100, etc damage, in place of spawning however many hundreds of individual particles?
I think that may defeatthe purpose of the particles altogether if they generate in a misleading count.
I think past a certain point you can't tell the difference, it's a difference between "a lot of particles" and "a lot of particles". It may not be ideal, but it would be good as a safeguard to make sure we don't spam the client.
I guess you're right, perhaps I'm just being too anal about this. I've changed my mind, I will simply just make it so up to 25 hearts can display at one time. Perhaps I can make it so one of the hearts is abnormally large to indicate that the particle cap has been reached.