Et Futurum Requiem

Et Futurum Requiem

Mods
105k Downloads

Vanilla "Smooth" Double Slabs have inconsistent drops

connor135246 opened this issue ยท 1 comments

commented

Initial Questions

  • I have searched this issue tracker and there is nothing similar already, and this is not on the list of known issues. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I have verified that this issue occurs in a SUPPORTED environment, meaning I can reproduce this WITHOUT OptiFine, and without Bukkit+Forge server software like KCauldron, Thermos, Crucible, Mohist etc

Mod Version

2.5.1

Describe the Issue

Breaking minecraft:double_stone_slab:8 drops etfuturum:smooth_stone.
However, breaking minecraft:double_stone_slab:9 does not drop etfuturum:smooth_sandstone and breaking minecraft:double_stone_slab:15 does not drop etfuturum:smooth_quartz. These should probably be consistent.

Relevant code:

Et-Futurum-Requiem/src/main/java/ganymedes01/etfuturum/core/handlers/ServerEventHandler.java

Lines 1735 to 1741 in 52f43ff

@SubscribeEvent
public void onDrops(BlockEvent.HarvestDropsEvent event) {
if (ConfigBlocksItems.enableSmoothStone && event.block == Blocks.double_stone_slab && event.blockMetadata == 8) {
event.drops.clear();
event.drops.add(ModBlocks.SMOOTH_STONE.newItemStack(1));
}
}

Conflicting Mods

No response

Crash Report

No response

Other Details

No response

commented

Ooh, nice catch. I forgot about those variants.