Eureka! Ships! for Valkyrien Skies (Forge/Fabric)

Eureka! Ships! for Valkyrien Skies (Forge/Fabric)

3M Downloads

minecraft:snow_block and possible minecraft:light need to be added to the blocklist

spottenn opened this issue · 4 comments

commented

This issue occurs when only Valkyrien Skies and addons are installed and no other mods

  • I have tested this issue and it occurs when no other mods are installed

Minecraft Version

1.20​

Mod Loader

Fabric

Issue description

When in snowy slopes and similar, if your ship accidentally touches a snow block and you hit asssembly, all the connected snow blocks also get assembled into the ship. We accidentally made a giant mountain range sized ship with this. I'm a developer and I looked through the code, The correct file to add it to is "Eureka/common/src/main/kotlin/org/valkyrienskies/eureka
/EurekaConfig.kt"

Also, the light block should probably be added because the user doesn't expect the ship to include light blocks and our shipping was touching the snow blocks via a light block.

Issue reproduction

Go to any biome with many adjacent snow blocks (not just snow, but full snow blocks) and stick a helm on one of blocks and look at the hitbox size of the ship (f3+b).

Logs

No response

commented

Since Snow is available in all versions, the blacklist would need to be updated on all versions. Since 1.20 is behind 1.19, as long as snow is added to 1.16, 1.18, and 1.19; all versions will In the future have the correct blacklist.

You said that you are a developer yourself, feel free to make a pull request.

commented

technically not a bug, just not a desirable outcome, you can add snow manually to the blacklist by editing the config

commented

also light cant be assembled

commented

merged to main