Tick Loop (AE2)

Question

Tick Loop (AE2)

Shadowhunter82 opened this issue 10 years ago · 20 comments

Shadowhunter82 commented 10 years ago

Hello
Found ah new bug!

http://pastebin.com/7SddPEni

Speiger · Answer 1 · 2014-09-07T14:22:47.000Z

@Shadowhunter82 when did that happen? When your AESystem did craft something?

Shadowhunter82 · Answer 2 · 2014-09-07T14:39:38.000Z

Thats the main problem i don´t know, It happend on my server. and there are ah view people on it with the autocrafting from AE

Speiger · Answer 3 · 2014-09-07T15:18:56.000Z

Test it in singelplayer. or make a server on your pc on put the mods in and try to crash it with this bug.

iTitus · Answer 4 · 2014-09-07T15:27:13.000Z

AE2 is throwing the CraftEvent but with a null-Playerobject, @AEnterprise should implement a null-Check there.

Am 07.09.2014 um 17:18 schrieb Speiger [email protected]:

Test it in singelplayer. or make a server on your pc on put the mods in and try to crash it with this bug.

—
Reply to this email directly or view it on GitHub.

AEnterprise · Answer 5 · 2014-09-07T18:18:50.000Z

@Speiger this just prevent all possible crashes, easier solution and it works

Speiger · Answer 6 · 2014-09-07T15:32:27.000Z

@iTitus i did think that too but could be possible that the fakeplayer of them had some problems.

iTitus · Answer 7 · 2014-09-07T15:44:38.000Z

Trying to reproduce now

iTitus · Answer 8 · 2014-09-07T16:16:44.000Z

Ok, its definetely a broken FakePlayer: the playerNetServerHandler is null while it tries to send a message in "addChatMessage(IChatComponent)"

AEnterprise · Answer 9 · 2014-09-07T16:17:49.000Z

@iTitus so this has to be reported to AE2 then? should i do a null check for that?

iTitus · Answer 10 · 2014-09-07T16:19:28.000Z

Yes, I think so, I was able to recreate this with only AE2, BC6 and BCA. When I created the right amount of Tools via Autocrafting it crashed with the same crash log.

iTitus · Answer 11 · 2014-09-07T16:21:20.000Z

You could check if player.playerNetServerHandler is null before sending a message but this should be done at AE2's end, I think

AEnterprise · Answer 12 · 2014-09-07T16:23:10.000Z

the right amount, so did you make progresss if you look in your book?

iTitus · Answer 13 · 2014-09-07T16:23:56.000Z

I will check now, I have to restart MC

iTitus · Answer 14 · 2014-09-07T16:26:22.000Z

My Player did not make any progress. But it keeps crashing as long as the crafting operation is running (I requested 60 Wooden Pickaxes...)

BigXplosion · Answer 15 · 2014-09-07T16:26:51.000Z

You should just add a null check like iTitus said, but you can't really blame AE2 (and other mods that can cause this problem) for this, as I don't think there is a better way of throwing a CraftEvent without having a normal player.

AEnterprise · Answer 16 · 2014-09-07T16:27:38.000Z

alright will add a null check

BigXplosion · Answer 17 · 2014-09-07T16:30:36.000Z

Also it's normal that auto crafting stuff via AE2 or other mods doesn't progress the player as there is no player specified. the same thing is happening for the HQM quest if you have a crafting task, only the player crafted items help you progress.

AEnterprise · Answer 18 · 2014-09-07T16:31:45.000Z

did it with a try catch as there might be other issues with fake players, this will take care of all of them

iTitus · Answer 19 · 2014-09-07T16:50:25.000Z

Also a possible solution ;)

Speiger · Answer 20 · 2014-09-07T17:17:43.000Z

Why not make a FakePlayerTestfunction?

Share to