EverlastingAbilities

EverlastingAbilities

9M Downloads

Make loot tables configurable in Fabric

Shibward opened this issue · 2 comments

commented

If possible, it'd be great if compatibility could be added for the mod 'When Dungeons Arise' as well as 'When Dungeons Arise - Seven Seas' so that the ability totems could spawn naturally in the mod's loot tables.
Tried teaching myself datapacks to see if i could add it myself, but not sure what function to call in order to get the totems to appear with an ability instead of empty.

If native compatibility cant be added, i'd appreciate if i could get some information so that i can try to add them via datapack.

I'm trying to get this working in Fabric 1.21.1.

Thanks.

Link to the mods below:
https://www.curseforge.com/minecraft/mc-mods/when-dungeons-arise-fabric
https://modrinth.com/mod/when-dungeons-arise-seven-seas

  • ➕ Feature request
commented

Thanks for the suggestion!

commented

In Forge/NeoForge, this would be possible via a datapack, but not in Fabric unfortunately.

We need to add an extension point for this: https://github.com/CyclopsMC/EverlastingAbilities/blob/master-1.21/loader-fabric/src/main/java/org/cyclops/everlastingabilities/item/ItemAbilityTotemConfigFabric.java#L37C50-L47
We can probably convert that field into a string list, and add the @ConfigurablePropertyCommon annotation to make it easily configurable.

GitHub
Entry for The Modding Trials 2016. Contribute to CyclopsMC/EverlastingAbilities development by creating an account on GitHub.