Rewrite of damage resistance and passive potion effects
CplPibald opened this issue · 2 comments
Issue type: ➕ Feature request
I'd like to do a rewrite of many of the passive abilities and re-implement several of them without adding vanilla potion effects to the player. Partly as a fix to #47, but also as a way to add more granularity. For example:
-
Fire Resistance could have multiple levels where each one reduces fire and lava damage taken more, and flames are extinguished sooner. At max, you get the immunity to lava damage and can't be set on fire.
-
Water breathing ability has four levels. 1-3 are like having respiration on a helmet and possibly a reduction in drowning damage. 4th gives full water breathing.
-
Jump boost, strength, speed, haste can be implemented using attributes instead of potion effects.
-
Add new resistance abilities to specific damage types like projectiles or fall damage. Normal "Resistance" gets a lot more expensive.
-
New abilities like Frost Walker or Thorns that currently come from enchantments instead of potion effects.
These new effects could replace the potion-based ones, or it could be configurable.
I'd like feedback or suggestions before I try to implement any of this.
Interesting idea, but it would require a lot of work, and would be something for a version 2.0.0.
The main downside would be that this would increase maintenance effort, as we now can reuse the already-implemented and tested vanilla potion effects. Also, certain things will require copy-pasting of vanilla code, which is unfortunate.
Also, we would need to take care of conflicts with the actual vanilla potion effects, and implementations by other mods, which would add additional complexity.
I like the idea of making it configurable, so that people can still disable the non-potion-based effects if they would cause problems or are not wanted.
Before you would implement any of this, I suggest making a detailed description of how every (changed) ability would work, as I'm not entirely convinced of the idea.