
[🗳️] Handling edge cases (Missing wood blocks)
Closed this issue · 11 comments
I would like to suggest a way for detecting wood types that are missing logs or planks or any other wood item (stripped logs, etc): Tag each block (e.g. re:deco table) with "wood dependencies": which wood block types are needed to craft or generate the texture for the block. This will allow EC to generate blocks for wood types that are missing blocks, for example, nahuatl from tconstruct is missing logs and stripped logs. But shouldn't blocks that don't require logs be generated for it?
Ok. First thing to do is Report it to the DEV and see if he can add the log or stripped_log for the WoodType that is lacking both.
Second: It's not worth to add in EC to generate log/stripped_log for a WoodType that don't have log/stripped_log. Because it's a rare case. First (above) is the best solution.
Third: EC's purpose is to create a compatibility between Wood mods and mods with furniture/decorative blocks. logs and stripped_logs are common in Minecraft and Wood mods that add new Woodset. that's why i pointed out in the Second that it's very rare.
This is impossible. Tags don't even physically exist when textures are generated. Tags are a concern of the server and get loaded on server load and even depend on which world/server you are in. Mods that add wood types with odd conventions are heavily encouraged to use Every compt API to add them themselves. Please ask there for compatibility
No i'm not saying EC should generate log types, EC should only generate blocks that do not need logs to be generated. For example, vertical slabs or stairs could be generated, even if the wood doesn't have logs.
Having a log is bare minimum to be eligible for wood detection. Without that the system would be much more brittle with more false positives. A wood set needs to have at least planks and a log equivalent block to be considered and useful as such, also because so many recipes would then use the log
I mean metaphorically tags, not actual #tags. Just like store somewhere what wood blocks are needed. Example: vertical slabs need planks, hollow logs need normal and stripped logs (for the inside).
Wood system is not as granular. Once one is detected tho we have such a system for blocks. Many don't gen added if the block doesn't have a stripped log for example
FYI, tags, recipes, and loot_tables are loaded when you are loading into world.
Blocks/items are registered during the launching stage. Like he said it's impossible to use tags.
EDIT: also that's why i recommend you to report it to the DEV to add log/stripped_log for the WoodType that is missing it. it's the most simple solution. there's nothing that can be done for the WoodType that don't have the log/stripped_log
And the reason why it's all inside the mod and not on an external configuration file is because it has to. Otherwise you wouldn't be able to connect on a sever with same mods as registries might differ