Code of Conduct

• Always check you are using the latest version of the mods and its dependencies
• Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue still persists.
• If you are unsure which mod is the culprit.
  Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
• Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version - Loader (DO NOT FORGET TO SELECT THE CORRECT VERSION)

1.20.1 - FORGE

EveryCompat Version

1.20.-2.8.16

Moonlight Lib Version

1.20-2.15.7

Issue with mods

gardens_of_the_dead
luminous_nether
biomeswevegone
aether_redux
aether

Issue Detail

Most recent update (did fix mushroom logs btw) also happened to remove at least 8 blocks, these are

everycomp:q/gardens_of_the_dead/vertical_whistlecane_planks (no woodtype, comes from whistlecan (like bamboo))
everycomp:q/luminous_nether/ash_hedge (withered wood)
everycomp:q/biomeswevegone/araucaria_hedge (pine wood)
everycomp:q/biomeswevegone/palo_verde_hedge (oak wood)
everycomp:q/biomeswevegone/flowering_palo_verde_hedge (oak wood)
everycomp:q/biomeswevegone/holly_berry_hedge (holly wood)
everycomp:q/aether_redux/blighted_skyroot_hedge (skyroot wood)
everycomp:q/aether/crystal_fruit_hedge (crystal wood)

I actually just fixed my hedge recipes earlier today with craftweaker, only the lattermost two had the wrong log type (blighted skyroot defaulted to oak, crystal fruit defaulted to I think oak as well but can't remember for sure)

OPTIONAL: Latest.log | Crash-report Attachment

No response

OPTIONAL: To Produce

Have all the mods, definetly everycomp and moonlightlib up to date, the others don't need to as long as you have the root wood/leaves

ok. just check,

• ancient_aether:wyndcaps_holiday_tree - aether:skyroot_log (WOODTYPE)

correct? if all is good, then i can use the table to add them in Moonlight Lib

I didn't specify enough with ancient_aether oops, its just a copy paste of the aether:holiday_tree configured feature but without presents under it, lost_aether_content also copy pastes it but removes presents.

the issue is that aether_redux only patches the aether:holiday_tree feature and not ancient_aether:wyndcaps_holiday_tree or lost_aether_content:holiday_tree so only the rarer holiday trees with presents become glacia

everything else was wrong before and you matched it correctly yes.

Yes this is correct WITHOUT aether_redux installed

you got it to switch correctly for crystal leaves I thought yeah? same thing for holiday

alright. the one with "( )" like aether_redux, i can set it to switch to that WoodType if the mod is installed. like aether_redux, there is already one case like that in Moonlight Lib for aether and aether_redux

so everything is all good to go?

EDIT:
@ImpulsiveLass
Just checking, everything is correct in the latest version of Moonlight, v2.15.7 or v2.16.0?

EDIT 2:
nvm. I see some need updating.

2.16.0 still caused the originally listed hedges and whistlecane vertical planks not to load so I haven't updated yet.

but yes you got all the woodtype matching and the switch for holiday correct

oh ic

I double checked and I have 36 hedges I had to fix the recipes for in my pack in total, I // them out for now, I have 104 total leaves so I will hand check them all again when it pushes

Not exactly. Meh already uploaded v2.16.3 an hour ago. that version don't have the updated code for this issue. so yeah The v2.16.4 will take a while to get approval.

on 2.16.2 moonlightlib and 2.8.17 everycompat, I am still missing those 14 hedges and whistlecane planks

That's because I haven't included it in moonlight lib yet.

so it will be included in the next version.

UPDATED in Moonlight Lib v2.16.4+

oop updating now

ugh. make that v2.16.4

EDIT: When v2.16.4 is out, let me know if you find any LeavesType that need some correction.

yeahh

forgot to rebuild the jar?

Can you please get me the mod_id for 1 to 11 especially last one, 11th.

EDIT:
alexscaves:ancient_leaves now have the correct WoodType. whistlecanes has the planks. but vertical_slab required "slab" to craft. I'll check

those first 11 are all biomeswevegone mb

it says the woodtype is alexscaves:ancient when it should be minecraft:jungle

those first 11 are all biomeswevegone mb

it says the woodtype is alexscaves:ancient when it should be minecraft:jungle

ok. got it. and yeah i know. Wait a min. You say alexscaves:ancient is a WoodType?? I believed you meant quark:ancient

yes i know. it should be using minecraft:jungle but something is wrong with the logic in Moonlight Lib so i am investigating to see what happened.

EDIT: ah i found the wrong logic. fixed it.

ok its almost good now, still missing the whistlecane vertical planks but nothing else now

Right, i forgot about whistlecane, i'll check now

EDIT: Alright, i'll do a quick test on Garden of the dead's whistlecane to make sure it's working properly.

oh and there is still 11 missing hedges (keep in mind they were there in 2.15.6,)

1. Orchard - Oak
2. Flowering Orchard - Oak
3. Ripe Orchard - Oak

Image

4. Palo Verde - Palo Verde
5. Flowering Palo Verde - Palo Verde

Image

6. Yucca - Oak
7. Ripe Yucca - Oak
8. Flowering Yucca - Oak

Images

9. Firecracker - Oak

Image

10. Araucaria - Pine

Image

11. Holly Berry - Holly (just holly hedge is added)

Image

https://streamable.com/n5aq8j
(alphabetical sort my beloved)

this is an improvement, holiday and crystal are all good now.

with the 93/104 hedges I have now, only two have the wrong woodtypes:

aether_redux:gilded_oak is still going to oak when it should be skyroot wood (same issue which happened with blighted_skyroot but that is fixed now)

Image

and alexscaves:ancient_leaves still uses quark:ancient_logs which it should be minecraft:jungle_logs

Image

From 1 to 11, which mod ID are they from? 4 and 5 should be included. i need to check if the mod_id is correct, 😩

and the last 2: aether_redux:gilded_oak, weird. it should be using skyroot.... OOOH so that's why.

it's actually "aether_redux:gilded_oak" not "aether:gilded_oak".

and the last one is correct. idk why it's not working. i'll have to do a quick test on that one.

alexscaves:ancient_leaves with minecraft:jungle_log

biomeswevegone

last is biomeswevegone:holly_berry_leaves

You say alexscaves:ancient is a WoodType??

no you said that

Image

Can you please get me the mod_id for 1 to 11 especially last one, 11th.

EDIT: alexscaves:ancient_leaves now have the correct WoodType. whistlecanes has the planks. but vertical_slab required "slab" to craft. I'll check

whistlecane does have a slab gardens_of_the_dead:whistlecane_slab, I don't have vertical slabs enabled in my pack since I have additional placements

whoa. on my side, it was "quark:ancient" for WoodType.

I don't meant "modId" i meant the id of these leaves

for example:

LeavesType - WoodType
---------------------
flowering_palo_verdo - palo_perdo

hh ok

• biomeswevegone:orchard_leaves

• biomeswevegone:flowering_orchard_leaves

• biomeswevegone:ripe_orchard_leaves -> oak

• biomeswevegone:palo_verde_leaves

• biomeswevegone:flowering_palo_verde_leaves -> biomeswevegone:palo_verde_log

• biomeswevegone:yucca_leaves

• biomeswevegone:flowering_yucca_leaves

• biomeswevegone:ripe_yucca_leaves -> oak

• biomeswevegone:firecracker_leaves -> oak

• biomeswevegone:araucaria_leaves -> biomeswevegone:pine_log

• biomeswevegone:holly_berry_leaves -> biomeswevegone:holly_log

please don't use the tags. use the WoodType's ID. 🤦🏻 tags is not the important part. dont worry about it. i can tell they are tags. just need to exclude "s"

well most have 4 wood blocks i know u r going to get the tag anyway

I don't have to get tags because EC will check if these WoodTypes have the tags or not. if they don't, then it will generate a new tag for the WoodType. Most Wood mods include a tag for their WoodTypes.

EDIT:
can you check to make sure everything are correct:

Details

EDIT 2:

don't worry about palo_verde_leaves blc it has the same ID as WoodType.

yes that is correct

Alright, everything have been corrected. so i'll upload v2.16.5 to Curseforge/modrinth after i run one more test

ok, i will check before i eep

v2.16.5 UPLOADED!

that should got everything resolved.

let me check

still no vertical whistlecane planks

all of the hedges are correctly lined up with their woodtypes but palo verde/flowering palo verde is still missing (102/104)

it looks like you typed it in correctly, perhaps it is because palo verde becomes birch? (doesn't have full wood set of its own)

which supported mod has vertical planks?

EDIT:
nvm. i know why.

it was excluded because the texture is pretty much same. it's impossible to rotate the planks to be vertical.

it was excluded because the texture is pretty much same. it's impossible to rotate the planks to be vertical.

its the same as bamboo??

Image

u just have the shoots go up/down instead of horizontal

those are not the same block, one is vertical, the other is the block of whistlecane which is NOT the planks

it's not that simple. Here's the picture:

Image

You can see the whistlecane_planks is pretty much no different from vertical_planks. even i turn it horizontal which defeat the purpose of "vertical_planks". so it's excluded. that's all.

the same happens with bamboo when u use the stripped block

the planks are a lot cheaper, they are not the same

I took another look at the image i made. i used the wrong block, i meant to use planks 🤦🏻

EDIT:

whistlecane is no longer excluded.

INCLUDED in EveryCompat (Wood Good) v2.9.0

Alright, everything is resolved. so i'll be locking this conversation after 10 minutes.

ok i must eep i have work gn

I will harass u again if I find buggies :3

(thank u for help and quick responses)

np! create a new issue if you find more bugs. lol. good night!

check what?, the leaves to wood matching?

aether_redux:blighted_skyroot_leaves should use skyroot wood
aether_redux:gilded_oak_leaves should be use skyroot wood
aether:crystal_fruit_leaves should use crystal wood which is from aether_redux if installed, standard crystal was correct

aether:holiday_leaves and aether:decorated_holiday_leaves are a bit of a mess:

aether alone -> skyroot wood

aether redux replaces it -> glacia wood

ancient aether adds its own seperate holiday trees it uses with -> skyroot wood

lost aether content duplicates the original feature exactly -> skyroot wood

(for my pack I'm replacing all to use glacia)

luminous_nether:ash_leaves should use withered wood

biomeswevegone:araucaria_leaves should use pine wood

alexscaves:ancient_leaves should use jungle wood, looks like it searched by string and found quark's ancient wood

https://streamable.com/bzbkdz

p.s.

palo verde and flowering palo verde go to palo verde logs
biomeswevegone:palo_verde_leaves
biomeswevegone:flowering_palo_verde_leaves
biomeswevegone:palo_verde_log

alright, these full ID like biomeswevegone:palo_verde_log will help me get it done faster.

thanks for the info!

its tags isn't it?
#biomeswevegone:palo_verde_logs
#biomeswevegone:pine_logs

withered doesn't have a built in tag oops
but it has the full 4 wood blocks
luminous_nether:withered_log
luminous_nether:withered_wood
luminous_nether:stripped_withered_log
luminous_nether:stripped_withered_wood

#aether:skyroot_logs
#aether_redux:glacia_logs
#aether_redux:crystal_logs

Also if I update the leaf textures for hedges, would I just be able to mimic the quark files blockstate, models, and textures? If I had to guess its probably two cubes one takes the wood/hyphae texture and the other takes the leaf texture, I'm going to add tintindexed overlays to 4, fieldsproot would required a mapColor assigned blockstate with 7x models and 7x textures but I don't think I'd be able to add it without forking quark like I did with immersive_weathering leaf piles

My Flowering and Ripe Yucca next to current hedges (old auto generated leaf piles were the same before I hand remade them all)

Image

Fieldsproot Leaves

Image 2

I believe I gave all the block ids and tags, unless you mean the variable it uses in the code or class name?

I can find stuff if u want me too

Can you check to make sure all are correct. above. I can update if one is incorrect.

its tags isn't it?

I'm talking about the Id of these blocks. LeavesType's ID is not the same as WoodType's Id, i can add WoodType to be LeavesType's associated WoodType. This way Quark's Hedge can be generated with LeavesType and its associated WoodType being available.

EDIT:
on another note - the tags are used in recipe to craft the hedge. EC automatically check for existing tag for WoodType, if it does, then that tag will be used. Otherwise, creating a new tag if it doesn't exist.

very few mods do not have a tag for their woodtypes.

I actually just fixed my hedge recipes earlier today with craftweaker, only the lattermost two had the wrong log type (blighted skyroot defaulted to oak, crystal fruit defaulted to I think oak as well but can't remember for sure)

can you check to be sure. I can correct them. LeavesType with Associated WoodTypes