Every Compat (Wood Good)

Every Compat (Wood Good)

28M Downloads

[๐Ÿž]: Doubled Loading times.

taz1009 opened this issue ยท 34 comments

commented

Code of Conduct

  • Always check you are using the latest version of the mods and its dependencies
  • Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue still persists.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version - Loader (DO NOT FORGET TO SELECT THE CORRECT VERSION)

1.21.1 - NEOFORGE

EveryCompat Version

Everycomp-1.21.1-2.11.2-neoforge

Moonlight Lib Version

Moonlight-1.21-2.23.3-neoforge

Issue with mods

.

Issue Detail

For some reason, updating from version 2.10.14 to anything higher will double the loading times of the pack.

OPTIONAL: Latest.log | Crash-report Attachment

https://mclo.gs/P5GR8MX <---- With version 2.10.14

https://mclo.gs/dyipmvJ <--- With version 2.11.2

OPTIONAL: To Produce

Update from 2.10.14 to anything higher.

commented

hello, did you downgrade moonlight lib here aswell or just EC?

commented

can you replicate this consistnetly? maybe was just pc busy?

commented

nevermind i see from the logs. interesting. i dont see anything suspicious, it all seems to go slower

commented

also can you go in every compat setting and set generation mode to ALWAYS? and test if it happens there?

commented

also without changing the config, new EC version use resource cache. this means first boot will be slower than before as it has to save assets to disk but consecutive ones could be faster as it wont have to generate stuff at all

commented

can you replicate this consistnetly? maybe was just pc busy?

It does this everytime, i even timed it as i was testing all the new updated mods after seeing it and consistantly EC doubled the time to load.

also can you go in every compat setting and set generation mode to ALWAYS? and test if it happens there?

Changing this to always has seemed to make the loading time correct again.

commented

how many mods do you have in the modpack?

EDIT: my best is it should be between 390 and 400 mods.

commented

mind sending the log from a second loead you did? one in which it will have used the cache saved to disk on previous boot

commented

also do you notice same thing when using CACHED config? from my testing, with fewer mods, i cant replicate

commented

Im running a NVME WD Black SN850X, and Ryzen 9 7900x cpu.

commented

how many mods do you have in the modpack?

EDIT: my best is it should be between 390 and 400 mods.

I have 322 mods.

mind sending the log from a second loead you did? one in which it will have used the cache saved to disk on previous boot

https://mclo.gs/vBwEZ5j <-- Second load with ALWAYS.

also do you notice same thing when using CACHED config? from my testing, with fewer mods, i cant replicate

It was set to CACHED_ZIPPED before the ALWAYS. CACHED loads slow first time, then second load is good.
https://mclo.gs/QilWAwN <-- Second load.

Doing the same with the CACHED_ZIPPED, that's the one that seems to be more than doubled every time loading without fail.
https://mclo.gs/ovY8y5O <-- CACHED_ZIPPED second or third load.

From all the testing I shall leave it on ALWAYS as that seems the best.

Sorry for so many logs

commented

ah interesting. thanks for testing thats useful and unexpected. the zipped one was added because others thought it would be much faster than loading from folders.
I sort of suspected that disk access due to its nature might be slower on larger packs ,outweightthe very slow pocess of texture gen itself, thats why i never added this cache till now.

Speaking of fo you have a SSD or HDD?

commented

@MehVahdJukaar

So you mean it takes ages to load the first time or second time? Also in confused. Do you mean on your client it makes it way slower and on the server it makes it way faster? (There's 2 configs one common and one in client, which is it?)

Sorry for beeing unclear I was going from taz perspective since I have the very same problem.

It takes ages to load on client side every single time as long as I have CACHED_ZIPPED set in my everycomp-client.toml.
As soon as I change it to "ALWAYS" like TAZ it takes significant less time to load /start.

On Server side it makes the startup from my server faster using everycomp-common.toml with the "CACHED_ZIPPED" setting.
(The Server has 346 mods)

commented

Just a quick note I have 422 mods active and having it set to CACHED_ZIPPED takes ages to load while setting it to "ALWAYS" drastically improves loading times. Also NVME.

Tho "CACHED_ZIPPED" on my server sides cuts down the startup time by some (around 1 min)

commented

So you mean it takes ages to load the first time or second time? Also in confused. Do you mean on your client it makes it way slower and on the server it makes it way faster? (There's 2 configs one common and one in client, which is it?)

commented

I see. Very inconsistent it seems. Client generation is way slower too since it has to make all those textures, on comparison server stuff is just some text replaces and has way fewer files. That tho would check out if the bigger the pack is the slower the time to query it would be. To note that I believe if everycompat was done like other mods with static assets, you would likely notice the same slowdown you see with cache zipped as that's how mods normally store assets. Quite baffling that generating stuff as runtime is faster than doing it normally . Tho maybe not that surprising given it's less disk access. Anyways do you mind testing the cached config too? That doesn't use a zip file. You might have to delete the generated cached folder tho, it currently does not do that if you swap between those 2 (also changing pack order or loaded mods eorks too)

commented

I found with the CACHED version it is slow first time but back to normal load times second time around.

commented

also CACHED is supposed to be slower on first but on second load if its not noticeabley faster than generating stuff then it also defats the purpose.. it should be noticeabley faster there as its skipping gen and just loading a normal resource pack instead

commented

would any of you mind testing this? (unzip)

everycomp-1.21-2.11.1-log-neoforge.zip

It just has some extra logging.
I would need a run with that and the CACHED_ZIPPED config set an sending latest.log with that. It might say which part was slow.

ALso having the same log but for ALAWYS and CACHED would be nice as i could compare them and see.

I still dont exclude it could be a compat issue with some mods given in my limited testing wtih fewer mods im getting the results im expecting with cached_zipped always winning, albeit not by much.

Also technical note:
the client config alters client generation. that runs on game start
server config alters server assets gen. that runs on serverstart/world load

commented

MehVahdJukaar:

Anyways do you mind testing the cached config too? That doesn't use a zip file.

Cached Time:
Cached 1st 5:23
Cached 2nd 2:40

So it does indeed help a lot. Will try now your version with extra logging to get the logs for you.

commented

But out of blue guess the "everycomp-dynamic_resources" Folder has 128.985 Files. Anyone who's ever unzipped a folder packed with tons of tiny files knows it takes forever compared to one with a few large files, even if the total size is the same. I'm thinking the ridiculously long loading time might just be from the system having to unpack that insane amount of files every single startup.

(if thats what happens on startup?)

But will generate the logs in a few!

commented

Yes that's very likely. Previous knowledge suggested that, intuitively, having a zip file would be faster than folders as the zip file should be internally unzipped once and kept in memory as opposed to constant disk lookups that normal folder access does. Also I'm not even compressing the files so unzip shouldn't take that much. Apparently it does. Well see with that report. I even know that merely looking up files in my in memory pack is way faster since I heavily optimized that, since I can given they are in memory. Vanilla stuff doesn't have any of that

commented

Just for reference first run took now 18mins 47secs
Do you need also the 2nd startup?

Latets. log https://mclo.gs/Ig19QPh

commented

oh my god 18m to boot

commented

yeah its the zip file, likely it opening. a run with spark mod +modern fix will likely confirm. I'll try to test myself later

commented

I changed ECConfigs to use "ALWAYS" for both CLIENT and SERVER. the other options is for Modpack Devs to use and determine which one is the best to use.

commented

so to re iterate, all things considered, for both of you, which works best? CACHED or ALWAYS?

commented

ALWAYS worked all the time first try no speed decrease. CACHED first time slow rest of the time fine.

commented

@MehVahdJukaar
Cached 2nd boot: 2 40s
Always: 3m 45s

So Cached is slighty faster on the 2nd boot, but since I have so many mods they update all alot so personally I probably stick witrh ALWAYS

commented

alright I'll change the default configs, its likely the cached mode will only be useful in some configurations. I have a new moonlight lib version that changes some of the infrastructure used so zip might be faster now. I tried to replicate but my laptop cant handle big packs, been at it for 30m. Guess you can try that version

commented

Gonna experiment with all this myself as well, but yeah within the last few updates (like in the last couple of days), my loading times exploded from like 150s to 1000s.

commented

Can i get the latest.log (just pure curiosity). You can use https://mclo.gs/

commented

Sorry for the late reply. For whatever reason, I can't reproduce the times I was getting before.

commented

Good