Every Compat (Wood Good)

Every Compat (Wood Good)

28M Downloads

[๐Ÿ—ƒ]: Apotheosis Compat?

Closed this issue ยท 15 comments

commented

Interestingly, the Bookshelf Variants EveryCompat generates don't have 2 Eterna. you can't fix it with a Datapack regardless, the Bookshelves will never accept any value from Apotheosis.

Image Image Image
commented
Sounds like Apotheosis has undetected WoodTypes, if yes, then I'm going to need some Ids for the following:
  • log: mod_id:oak_log
  • planks: mod_id:oak_planks
  • OPTIONAL: if Children has the same WoodType's name (oak), otherwise you can add children: mod_id:wicked_oak_stairs

EDIT:
hmm... Ignore above. Did EC produce other blocks with Eterna, then only bookshelf is not produced. Can you check if Eterna has its own bookshelf

EDIT2: I better check Apotheosis. I think there is more to this than what you said in your first post

commented

What minecraft version is this?

commented

no, I don't think it did.

okay, thank you for your time

1.21.1 Neoforge

commented

ok so what you are asking if EC could apply the Enchanting Stats to all of its bookshelves. If yes, then i'll have to take a look at Apotheosis's source code to see if it's possible or not.

commented

yeah, that's what I'm asking.

commented

alright, i'll check Apotheosis's source code

commented

Please speak with the DEV regarding the source code, I can't find the class that is responsible for adding "Eterna" to Bookshelf.

EDIT:
hold on, you said datapack? can i take a look at the file? The ID of everycomp has to be full id.

it would look like this everycomp:abnl/biomesoplenty/fir_bookshelf abnl is just a shortened ID for Woodworks

commented

regarding the source code, have you checked https://github.com/Shadows-of-Fire/Apothic-Enchanting ? apparently it's an addon for Apotheosis that added the Enchanting Modules, such as "Eterna".

ignore the datapack issue as that seemed to be 1.20.1 only, datapacks can make apotheosis compatible with ec on 1.21.1

yeah sure, I'll send it nonetheless
abnww_aurum_bookshelf.json

commented

I have checked Apothic-Enchanting and cannot find what i am looking. I do not realize the enchanting with eterna was actually a datapack stuff.

I'll take a quick look

commented

alright. and, yeah you can add compatibility with bookshelves using datapacks. the weird part tho is that Mods that add their own bookshelves tend to work as a normal bookshelf out of the box with apotheosis, no additional datapack compatibility needed.

while the bookshelves EC generates don't work out of the box, I had to manually add support using datapacks.

EDIT: Just tested a world with only EC, Woodworks and Regions Unexplored. it seems that the Bookshelves EC generates don't even act as Bookshelves

Images Image Image

In these Screenshots, you can see EC Bookshelves not bumping the Vanilla Enchanting lvl up, while the Vanilla Bookshelves do.

commented

ah. I think these bookshelf are missing the tag. which supported mod is it?

EDIT: nvm. it's woodworks. let me check

EDIT2: yup it's missing the tag, BlockTags.ENCHANTMENT_POWER_PROVIDER.

It's fixed in v2.11.7

commented

Going to upload v2.11.7 and let me know if that fix the problem

EDIT:
@UhCaleb it's uploaded! will take a while to get approval. let me know if v2.11.7 fix the problem

EDIT2:
please wait, i had to archive the v2.11.7, there are some issue with the new code that caused the crash and it's flawed.

commented

Please let me know if v2.11.7 fixed the issue. if it is, then you can close this issue. Thanks!

commented

It's fixed. Thank you!

commented

FIXED in v2.11.7


REASON: Woodworks' bookshelf was missing the tag, BlockTags.ENCHANTMENT_POWER_PROVIDER and it's why bookshelf from EC did not have the Enchanting Stats from Apotheosis