[🐞]: Create windows made from custom wood types have incorrect tags
Closed this issue · 7 comments
Code of Conduct
- Always check you are using the latest version of the mods and its dependencies
- Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue still persists.
- If you are unsure which mod is the culprit.
Disable all of your mods and enable them 1-2 mods each time to isolate the culprit - Confirm that there is no existing issue with a similar description submitted in the list of issues.
Version - Loader (DO NOT FORGET TO SELECT THE CORRECT VERSION)
1.20.1 - FORGE
EveryCompat Version
everycomp-1.20-2.9.6
Moonlight Lib Version
moonlight-1.20-2-16-14
Issue with mods
Create
Gregtech CEu Modern (GTCEuM)
Issue Detail
The generated window for gtceu:rubber has different tags (#forge:glass and minecraft:impermeable) to create windows (#minecraft:impermeable).
OPTIONAL: Latest.log | Crash-report Attachment
No response
OPTIONAL: To Produce
No response
ok just so i get this right.
Create's windows has
#minecraft:impermeable#forge:glass
correct?
create's windows do not have #forge:glass by default. Autogenerated windows do.
I remember why it was added. This was from Discord where a user reported
Not having the #forge:glass and #forge:glass_panes tags causes an incompatibility with the Botania vitreous pickaxe. However, making sure blocks have their proper tags will prevent more edge cases in the future.
It's not just Create. Chipped has the same tag for glass. this is a matter of compatibility.
when The mod is installed... Create's windows & window_panes has that tag. Chipped also has it, too.
EDIT: this is not a bug. this is intended for a purpose or a good reason.
Vanilla create windows do not work with the vitreous pickaxe withoout KubeJS, autgenerated windows shouldn't be tagged as forge:glass unless chipped is installed and it truly needs it, as it messes with recipes from other mods and causes a difference in behaviour. "Proper tag" is referring to relation to the original mod, if other mods only check explicitly for create windows, you should cover their cases and alter recipes, if they check for #forge:glass, create windows are not included.
alright, I've thought of a good solution for this. i'll have to talk with the guy who reported a bug for that. This will take some time for that guy to respond
Ok i've spoke with the guy. I'm going to make an improvement where the botania is installed, then the tags will be included for all of glasses including create's windows
otherwise, the tags won't be included for these blocks if botania is not installed.
UPDATE:
Improved the code. so it won't be included unless you have botania installed.