[1.20.1] [fml mod] No Better End woodtype support
Cixon opened this issue · 20 comments
Using Sinytra Connector, FML can easily run fabric mods now. I have Terrestria [fabric mod] installed and their woodtypes are not available to me; same with BetterEnd when using MrCrayfish furniture. However, fabric leaves (hedges) do appear and function great.
Image of BetterEnd Tenanea Hedge running on Forge:
Sinytra connector will be the next big thing so it's definably viable to get the woodtypes working since it appears the fabric leaves work out of box.
Sources:
https://legacy.curseforge.com/minecraft/mc-mods/sinytra-connector
https://legacy.curseforge.com/minecraft/mc-mods/forgified-fabric-api
https://legacy.curseforge.com/minecraft/mc-mods/betterend/files/4677967
(and BCLib, exclude Fabric API)
https://legacy.curseforge.com/minecraft/mc-mods/terrestria/files/4710309
https://legacy.curseforge.com/minecraft/mc-mods/mrcrayfish-furniture-mod/files/4602980
Ah hm just trying to think of some other I know really well and I'm sure work on fabirc only. Biomes o plenty?
Not available for 1.20.1 fabric
At least on curseforge..maybe there’s a build somewhere
That's weird, as far as I knew fabric mods were loaded pretty much same time as others but the static nature of their registration would make their blocks being added immediately, through connector hacks. What's werider is that leaves types work and others do not. Of those are indeed from the same mod it makes even less sense
Can you test with other mods that add wood, heck even terrestria on fabric version. Only explanation is that wood detection is somehow failing for those woods
Can you test with other mods that add wood, heck even terrestria on fabric version. Only explanation is that wood detection is somehow failing for those woods
The Terrestria mod doesn’t show any signs of their wood type working with Every Compat, I even tried Cinderscapes. I will say, there’s definitely forge wood type detection as you can see in the screenshot, that mod is gardens of the dead
https://legacy.curseforge.com/minecraft/mc-mods/gardens-of-the-dead
So I know for almost certain that terrstria woods and leaves register at same time. With fabric unfortunately there isn't really a dedicated step where that can happen tho but even fabric mod version works under that assumption and these woods do work there so I have absolutely no idea why the registries wouldn't be filled up when forge registers it's stuff
So I know for almost certain that terrstria woods and leaves register at same time. With fabric unfortunately there isn't really a dedicated step where that can happen tho but even fabric mod version works under that assumption and these woods do work there so I have absolutely no idea why the registries wouldn't be filled up when forge registers it's stuff
It could be a Sinytra error, I’d assume. I would @ Su5eD as that’d be our answer to this discrepancy. I’m no programmer so I couldn’t say for sure but it still begs the question as to why leaves show up and wood don’t…
I don’t think it’s open source but here’s github:
https://github.com/Sinytra/ForgifiedFabricAPI
I can't test these days but incase it doesn't work wood types for a couple more fabric mods (and leaves types are registered) the that would confirm tha wood type detection is somehow getting confused. Very weird as it's mostly I'd based and I checked connector loads fabric registries basically as soon as the game starts, way way before forge even loads mods. Confusing stuff . Can you try with twilight forest fabric?
Oh lol that would be cursed. Not only that but for how it's made it will not work as it will only see stuff registered by fabric mods
Ah hm just trying to think of some other I know really well and I'm sure work on fabirc only. Biomes o plenty?
I could attempt to use the fabric version of everycomp woodgood but this may result in the forge compat not working lol
Oh lol that would be cursed. Not only that but for how it's made it will not work as it will only see stuff registered by fabric mods
Made a discovery.....
Architectury API (forge version) ruins the wood registries for fabric mods.
I spent nearly the whole day diagnosing a bunch of things 1 by 1 and found that there's not anything inherently wrong with WoodGood. Disabling shedaniel's API fixed this bizarre situation with only leaves being supported by WoodGood.
It's 50/50 - some mods work, some don't, screenshot below shows Regions Unexplored (fabric)
It appears to be a shedaniel issue but again, I'm no programmer so maybe you could made a patch for the API?
One thing I know for sure is, BetterEnd isn't supported for the current WoodGood FML version.
Conclusion: Some fabric woodtypes work and some need manual support such as BetterEnd and Terrestria.
hmm isn't this enhancement for EveryCompat to work with fabric with Minecraft running Forge?
If yes, then perhaps, i should change the label to enhancement instead of module
the compat for terrestria doesn't work on 1.20 fabric too, is it an expected situation?
To be classified as a wood type a block needs to fulfil some characteristic that all wood types have such has having the bass sound type for noteblocks. Do those blocks have that? If not it's not my issue
To be classified as a wood type a block needs to fulfil some characteristic that all wood types have such has having the bass sound type for noteblocks. Do those blocks have that? If not it's not my issue
Well I tested, and I found that it has a harp sound for noteblocks...I will report it to them
To be classified as a wood type a block needs to fulfil some characteristic that all wood types have such has having the bass sound type for noteblocks.
OK but when you say "some" I wonder what the other assumptions are...
Also, we are talking about the planks block specifically, right?
And finally, we use FabricBlockSettings.copyOf() and I think this issue may be resolved when the following change is merged to FAPI: FabricMC/fabric#3373