Every Compat (Wood Good)

Every Compat (Wood Good)

28M Downloads

Deep Dark Bloom Wood

AbelRunes opened this issue ยท 11 comments

commented

So, Im not sure if this is a new wood type or not, but I noticed there's is a wood type called Bloom wood from Deeper and Darker that doesn't have any support added for this mod. The Echo wood does but not the bloom wood.
For example this is all the echo wood.
Image
And this is all the bloom wood available
Image

commented

It has sounds when you place it and break it if that's what you mean,

yes. that's the sound it make. It should have "bass" sound when you place it. the best way to know is place the wood block. then add the "note" block and play it so you can list the sound of that block.

regarding the ID, what about "log", too? Moonlight Lib detect woodType by 2 things: naming scheme and sound, BASS

naming like oak_log

commented

Does the Bloom Wood have "BASS" sound? if it doesn't, then you need to report it to DEV to correct the sound. and what's the ID of that wood. if it's unique ID, then I'll add it to Moonlight lib.

Also, what's the Minecraft Version?

commented

What do you mean by Bass sound? It has sounds when you place it and break it if that's what you mean, but the ID is deeperdarker:bloom_planks, it comes from a stalk in the deep dark dimension so there isn't a log ID
The version is 1.20.1

commented

So the wood it comes from is a stalk or stem, there isn't a 'log' type. But I'll do the sound a bit later. Since I stepped away from a moment. If not tonight tomorrow morning.

commented

So Yes the block has BASS sound and the 'log' is deeperdarker:blooming_stem its not really a log

commented

strange, it should be detected. I'll check.

commented

For the deeperdarker:bloom wood type that this issue is about (:
Normally undetected (due to 'bloom' in planks and 'blooming' in stem), which I added (for personal use) with:

var bloom = WoodType.Finder.simple("deeperdarker", "bloom", "bloom_planks", "blooming_stem");
        bloom.addChild("stripped_log", "stripped_blooming_stem");
        BlockSetAPI.addBlockTypeFinder(WoodType.class, bloom);

Now the "log block" has a cross-pattern texture, so not a full (edit: completely filled) 16x16 (and block size isn't a full block either), and doesn't have a blooming_stem_top texture (a log has both side and top) because of that.
iirc for example the everycomp:q/deeperdarker/hollow_bloom_log (/w quark) then had a missing texture on the inside of that log, but it's been a while since I checked

commented

Moonlight Lib is responsible for detecting WoodType. EC has a class that ensure the correct texture are selected for texturing the block or used for generating a new texture.

so magenta/black? from which wood mods?

commented

Duplicate of #601 no?
I've a personal unreleased mod that just adds it anyway through moonlight's api and it mostly works there's just a couple things that have texture issues (magenta/black) or texture gaps (for example beautify lattices) or look silly (less than a full block stem becoming a full block hollow stem, for example) and should maybe be blacklisted instead.

commented

ok got it.

I'll add that to Moonlight Lib

EDIT:

it's added.