[🐞]: Variant Vanilla Blocks do not count as Job Sites
Vixtoast opened this issue · 7 comments
Code of Conduct
- Always check you are using the latest version of the mods and its dependencies
- Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue still persists.
- If you are unsure which mod is the culprit.
Disable all of your mods and enable them 1-2 mods each time to isolate the culprit - Confirm that there is no existing issue with a similar description submitted in the list of issues.
Version - Loader (DO NOT FORGET TO SELECT THE CORRECT VERSION)
1.20.1 - FORGE
EveryCompat Version
everycompat-1.20-2.7.26
Moonlight Lib Version
moonight-1.20-2.13.82-forge
Issue with mods
Biomes O' Plenty 1.20.1-19.0.0.96
Variant Vanilla Blocks 1.3.6
Biomes O' Plenty adds various wood types, and Variant Vanilla Blocks adds variants of several Villager Job Sites
Issue Detail
Variant Vanilla Blocks adds several versions of Villager Job Sites using different wood. Grindstone, Smithing Table, Composter, etc. In the main mod, the variants with Vanilla Wood types count as their respecting profession sites. Those added by Every Compat for Biomes O' Plenty Wood (and presumably, all other modded wood types), do not count as Villager job sites.
The blocks with needed compat are as follows:
-Smoker
-Cartography Table
-Composter
-Barrel
-Fletching Table
-Lectern
-Smithing Table
-Grindstone
OPTIONAL: Latest.log | Crash-report Attachment
No response
OPTIONAL: To Produce
- Place a Variant Job Site Block added by Every Compat
- Spawn a Villager near it
- Observe as the poor thing twiddles its thumbs unable to get a job
UPDATE:
this issue is more troublesome. Meh and I have tried our ideas and villagers still don't turn into their profession.
Like i said this will take some time to fix
UPDATE 2:
@Vixtoast
This issue is more troublesome. Meh has created a method in Moonlight LIb, and it works on Friends & Foes. But it doesn't work on Variant Vanilla Blocks (VVB), it's due to @override in the method that prevent the method from Moonlight Lib to add blocks to the POI-Type which allow them to be counted as "job site".
right now, there is no solution for this. Frankly, the @override shouldn't be used at all because it prevent compatibility between 2 mods. Even an addon is created to support VVB with one wood mod. it may be difficult and tricky.
Not sure if this is related but as of moonlight version 2.18.13 and every compat version 2.11.0, the game crashes and will not load with VVB installed on neoforge.
latest: https://mclo.gs/Gip8Rep
debug: https://mclo.gs/0QRSu5E
ok i was confused by the version, v2.11.0. so i had to check the logs to see what version is it. so v2.10.4
EDIT: ok. yes this is related to here, the issue. i'll have to disable the code in 1.21.1. that's not good.
EDIT:
The code is disabled in EC 1.21.1, v2.10.5
just checked with latest update and i assume this is still disabled as none of the workstations (fletching, composter, cartography, lectern, smoker, smithing, grindstone) work ?