Issue type:

• 🐛 Bug

Short description:

Installing both GTCEu-Modern v1.6.2 and EvilCraft 1.2.49 results in Minecraft:Potion items getting an additional NBT on them. This causes issues with any other mod that adds crafting recipes utilizing a Minecraft:Potion because they expect the one NBT specifying the Potion type.

Steps to reproduce the problem:

1. Install GTCEu-Modern 1.6.2, EvilCraft 1.2.49, JEI v15.20.0.105, and for example Draconic Evolution v3.1.2.604
2. Start a world in Creative
3. Use JEI to bookmark the ingredients for the Damage Module from Draconic Evolution
4. Give yourself the ingredients
5. Hit F3+H and confirm that there are 2 NBT tags on the strength potion
6. Place a Crafting Table down and try to craft the Damage Module

Expected behaviour:

No added NBT to a Minecraft:Potion item so that crafting recipes using the potion still work

Versions:

• This mod: 1.2.49
• GTCEu-Modern: 1.6.2
• Minecraft: 1.20.1
• Mod loader version: Forge 47.3.11

Additional Information:

You don't need to install JEI or Draconic Evolution to reproduce this. Having just GTCEu-Modern 1.6.2 and EvilCraft 1.2.49 is enough to see that potions have an additional NBT stored on them.

Thanks for reporting!

AFAIK, EvilCraft does not add any tags to potions.
Can you report this to the GTCEu-Modern issue tracker and link back here?
Happy to make changes here if the GTCEu-Modern mod author considers it relevant.

Sure thing - I reported it here first since it doesn't happen with just GTCEu-Modern installed and appears to be a mod interaction, but I'll make an issue there too. Issue here

GTCEu-Modern recently added functionality where Potions are now a Fluid, and my thought was the additional NBT could be getting added so the Dark Tank would work properly with it.

What causes the poison bottle to have the NBT Fluid: {FluidName: "evilcraft:poison", Amount: 1000}? With just EvilCraft installed and no other mods. JEI shows a poison bottle with no NBT, cheating one into your inventory changes it to have that additional NBT.

This is what the added NBT looks like on the potions when GTCEu-Modern is also installed.