Crash when removing block below display stand
Closed this issue ยท 5 comments
Issue type:
- ๐ Bug
Short description:
User crashed the server when removing a block below a display stand.
Steps to reproduce the problem:
I cannot reproduce this issue locally, and its not happened since, so not sure if there was additional circumstances.
Problem could likely be solved by adding a null check to this function:
https://github.com/CyclopsMC/CyclopsCore/blob/1c141e0d4f7ebfcf2c52ad9ea3985f2997ab3abe/loader-common/src/main/java/org/cyclops/cyclopscore/helper/BlockHelpersCommon.java#L81
Expected behaviour:
Sever should not crash
Versions:
- EvilCraft: 1.2.78
- CyclopsCore: 1.26.2
- Minecraft: 1.21.1
- Mod loader version: NeoForge 21.1.203
Modpack: ATM10 4.10
(Note, I haven't contacted the modpack authors as I don't beleive that this is a modpack related issue)
Log file:
Ah, apologies, apparently those logs only last for 24 hours
This should be 90 days:
https://mclo.gs/GaDUW0w
mclo.gs657 lines
Your integrated dynamics, addons and dependencies, but not including EvilCraft itself, are outdated.
But, as you mention, the method mentioned in the error hasn't changed in those versions.
(just clarifying)
I had a look into this, and I'm suspecting there is a mod in your pack that is passing null ItemStacks into loot tables, which is illegal according to the API.
This exception was thrown in the EC codebase, but it could very well have been thrown in any other mod that handles loot tables.
I recommend identifying the offending mod (by iteratively removing mods from your pack), and reporting this to their issue tracker.