Make Blood Chest repairing consistent with Mending
Deuxis opened this issue · 6 comments
Issue type:
- ➕ Feature request
Short description:
Blood chests don't repair many items they should (Immersive Engineering tools, Silent's Gems anything(!!!)...). As far as I understand, durability is just the meta value of an item and repairing it is just bumping it up, why not just do it that way and do config options for white/blacklisting compatible items?
Even if not, most of those (Silent's Gems gear, for example) work well with Mending - why can't Blood Chest just simulate Mending using blood instead of exp?
That's exactly what we do: https://github.com/CyclopsMC/EvilCraft/blob/master-1.12/src/main/java/org/cyclops/evilcraft/tileentity/tickaction/bloodchest/DamageableItemRepairAction.java#L39-L40
Some mods simply do not allow repairing through non-standard methods, nothing much I can do about that other than adding custom support (such as for TiCon).
I can look into how mending is applied exactly, but I assume it's exactly the same as how I do it now. I suspect that Silent Gems just adds custom support for Mending.
GitHub
EvilCraft - An evil mod for Minecraft.
Just discovered that Powered Anvil from Cyclic works on Silent's Gems stuff. My bet is either simulated Mending or simulated vanilla anvil repairing.
Definitely interested in this. Making a new pack featuring SG and Evilcraft and was planning on using the blood chest to repair gear.
PRs are welcome, as I won't have time for implementing this myself anytime soon.
Oh, neat. I forgot I exposed an API for that.
SilentGems commit for reference: SilentChaos512/SilentGems@40b307e