Issue type:

• 🐛 Bug

Short description:

Setting the maxTankSize to a number smaller than the default does not properly limit the size of the tanks that can be crafted.

Steps to reproduce the problem:

1. Change maxTankSize to 64000 in evilcraft-common.toml in the config folder.
2. Craft 8 tanks together and get a tank holding 144000, more than the configuration should allow.

Expected behaviour:

Crafting of tanks larger than 64000mB should not be possible.

Versions:

• This mod: 1.2.10
• CyclopsCore: 1.7.10
• Minecraft: 1.19.2
• Forge: 43.1.57

Reproducible with no other mods installed.

Log file:

https://pastebin.com/1hVmQgu0

Thanks for reporting!

The maxTankSize has become deprecated in MC 1.18+, and can now be modified by overriding the dark tank combination recipe in a datapack like this: https://github.com/CyclopsMC/EvilCraft/blob/master-1.19/src/main/resources/data/evilcraft/recipes/special/combine_dark_tank.json#L4

Will remove this config option in next update to avoid confusion.

GitHub

EvilCraft/combine_dark_tank.json at master-1.19 · CyclopsMC/EvilCraft

An evil mod for Minecraft. Contribute to CyclopsMC/EvilCraft development by creating an account on GitHub.