(I will also post this on the other mod's tracker)

Issue type:

• 🐛 Bug

Short description:

Potential exploit in conjunction with Corail Tombstone. Tombstone perk "Alchemist" boosts the length of time that potions last, and the lengthened effects can be rebottled with a ``evilcraft:purifier`.

Steps to reproduce the problem:

1. Install both EvilCraft and Corail Tombstone
2. keep doing things in the latter until you get at least one Knowledge of Death level. I don't think there is a debug command to give yourself KoD skill points, but I think you can just keep granting and revoking advancements from the mod.
3. Make sure you have access to the Knowledge of Death perk menu one way or another, either by the Keybind or the chat message that shows when you level up
4. Open that menu and, using your KoD level, get a level of Alchemist
5. You can repeat step 2-4 to get higher levels of Alchemist for greater effect, but one level will suffice for this test
6. Obtain and place an EvilCraft Purifier
7. Place or pump blood into the Purifier. For this test, a creative source of blood pumped into the block's Fluid capability would be best so you don't have to keep refilling it, but failing that, any other method of bucketing blood into the machine will suffice. It needs to be full, though.
8. Put a bottle on top of the Purifier by right clicking it so the floating spinning item appears above the block model.
9. Give yourself a potion, either from Minecraft or any mod. I recommend at least one minute duration, maybe even more if you only have 1 level of Alchemy. If you've done everything correct so far, you should notice it has longer duration than you would expect from its item data (For instance, long_night_vision, which I recommend for this test, lasts 8:00 normally)
10. Stand in the purifier, and immediately drink the potion.
11. If the purifier is full of blood and a bottle and you are standing in it, the potion should be bottled up, now having a longer effect duration thanks to this exploit.

Expected behaviour:

DON'T let the player get infinite potion durations, at least not without a proportional cost.
On EC's side of the fence: since CyclopsLib seemingly supports storages with very large capacities (2^16 times some unit, specifically), maybe the blood cost should be proportional to the duration of the potion (possibly adjusted by its value if you can determine that somehow)?
On tombstone's side: there could at least be a config option to disallow Alchemy from lengthening "uncraftable" potions. Honestly not sure what else to do...

Versions:

• This mod: 1.2.16
• Corail Tombstone: 8.2.7
  -- (I can try updating the mods if you want, but it seems inherit to the design of the mods, not something likely to be accidentally patched.)
• Minecraft: 1.19.2
• Forge: 43.2.6

Modpack: all the mods 8, but despite your comment in the markdown of the issue template... I really don't think it's a configuration issue. Anyway I don't have time right this minute to try shortening the mods list for you. I'm pretty sure it will just happen with the two mods I mentioned anyway.

Log file:

Let me know if you need it, I'll happily provide if you think it will help. This issue doesn't really hide that well anyway though

Thanks for reporting!

Sure, we could scale the Purifier's blood cost based on the potion's duration.