[Suggestion] Make barrels milk cows that are standing on top of them.

Question

[Suggestion] Make barrels milk cows that are standing on top of them.

SirLyle opened this issue 7 years ago · 8 comments

SirLyle commented 7 years ago

Just a minor automation improvement that could be added. Maybe expanded into something that could be configurable for pack makers.

I'm still new to modding but I tried my hand at it (yay open source mods to practice on).

SirLyle · Answer 1 · 2017-09-01T22:27:04.000Z

I'm actually working on making it a definable recipe for any entity so that it can be adjusted for packs.

BloodWorkXGaming · Answer 2 · 2017-09-01T23:59:21.000Z

This is not a bad idea, not realistic, but funny ^^ However, my concern with it being the barrels doing the milking, they always tick and have to check for animals on top of them. The mob walk event isn't that useful as well, because they might sometimes stand still and won't get milked. Calling it every tick however will make lag, even if the barrel is not intended to be used as a milking thing.

…

On Sa., 2. Sep. 2017, 00:27 SirLyle ***@***.***> wrote: I'm actually working on making it a definable recipe for any entity so that it can be adjusted for packs. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#20 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHwpZhVFKGbO4RkcBtRk0HMWEMz5_Z6bks5seIS4gaJpZM4PIMQd> .

SirLyle · Answer 3 · 2017-09-02T07:25:04.000Z

onEntityWalk seems to be working when the cow is restricted to a 1x1 area over a barrel; which is how I imagine most people would set it up.

SirLyle · Answer 4 · 2017-09-05T02:01:44.000Z

Well I think I have it working using the entity walking event, a configurable cool down, and definable recipes. Works with caged mobs so I think the entity walking event is really an entity-on-top-of event.

The commit.

BloodWorkXGaming · Answer 5 · 2017-09-05T09:17:25.000Z

Cool! If you think you are done then just PR it in, then I'll merge it and read over it. Thanks ^^

…

On Di., 5. Sep. 2017, 04:01 SirLyle ***@***.***> wrote: Well I think I have it working using the entity walking event, a configurable cool down, and definable recipes. Works with caged mobs so I think the entity walking event is really an entity-on-top-of event. The commit <1.12...SirLyle:1.12> . [image: 2017-09-04_21 54 40] <https://user-images.githubusercontent.com/6723308/30041979-2aa30af0-91bc-11e7-9ff4-ab8330c47916.png> [image: 2017-09-04_21 55 47] <https://user-images.githubusercontent.com/6723308/30041980-2be798d6-91bc-11e7-9795-17480832eece.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#20 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHwpZuz2G3VU9kjjHZBUgiiJdssY6Rqrks5sfKuIgaJpZM4PIMQd> .

SirLyle · Answer 6 · 2017-09-05T21:45:42.000Z

There are a few scenarios I want to try to make sure it is stable. I will make a PR when I have satisfied my self QA.

SirLyle · Answer 7 · 2017-09-17T03:43:57.000Z

Not sure if you've seen but I made the pull request.

BloodWorkXGaming · Answer 8 · 2017-09-20T15:51:51.000Z

Merged the PR, thanks

Share to