Enchanting Meshes
NielsPilgaard opened this issue · 10 comments
Hey!
I was wondering, is it intentional that you cannot enchant meshes directly in an Enchanting Table or not?
Minecraft 1.12.2
exnihilocreatio-1.12-0.1.7.63
Honestly I am not sure anymore, I maybe did it tentionally because the
enchantment are freaking op and you get them 100% because there are no
other enchantments for meshes.
But it's too long so no idea anymore, might have to revisit it ^^
SirLyle <[email protected]> schrieb am Fr., 30. März 2018, 01:37:
… It looks like it is suppose to be able to apply the enchantments at the
table.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHwpZgZMxF9QgliQ5CEfl8upSqKzE4RJks5tjXBHgaJpZM4S9c0c>
.
All the enchantments have
public boolean canApplyAtEnchantingTable(ItemStack stack) {
return stack.getItem() instanceof ItemMesh;
}
so it is trying to allow for them to added in the table.
Alright, will have to check it out after Easter unless you want to? ^^
SirLyle <[email protected]> schrieb am Fr., 30. März 2018, 01:50:
… All the enchantments have
public boolean canApplyAtEnchantingTable(ItemStack stack) {
return stack.getItem() instanceof ItemMesh;
}
so it is trying to allow for them to added in the table.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHwpZuoVoVCUBaowpxI1HlI9iAsrHqj9ks5tjXNigaJpZM4S9c0c>
.
I'm looking at it now, it appears that the canApplyAtEnchantingTable is never being called on the meshes.
I found the issue, we just need to override isEnchantable to return true. The enchantability values seem all messed up and prevents anything but efficiency from being selected.
Maybe check whether the mapping changed in some of the mcp updates?
SirLyle <[email protected]> schrieb am Fr., 30. März 2018, 02:03:
… I'm looking at it now, it appears that the canApplyAtEnchantingTable is
never being called on the meshes.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHwpZqvespjDlTtDVjF7wsnJwrbpuQ_oks5tjXZGgaJpZM4S9c0c>
.