1.20.1 Forge Crash on Disconnect from MP server, likely Sinytra Connector issue
Atlantispy opened this issue ยท 6 comments
Hi,
I've found that I crash when leaving a MP server when having excavated variants and using it on a server with Sinytra Connector:
I've attached the Crash log, issue fixes when removing EV from the game.
Not to insult your intelligence by using AI, but Claude said:
Fix the BitIndex < 0: -1 error in registry synchronization. This occurs in the ForgeRegistry.add() method when the mod is trying to handle registry entries during the client disconnection process.
Specifically, they would need to examine their ForgeRegistryMixin implementation in mixin.excavated_variants_forge.json which is directly implicated in the stack trace.
The issue is likely related to how the mod handles dynamic block variant generation and tracking. When the client disconnects from a server, the game tries to revert registries to their pre-connection state (via GameData.revertToFrozen()), and the negative index is being produced during this process.
The fix would involve ensuring proper bounds checking before setting bits in the BitSet, or restructuring how they track and restore registry entries to avoid the negative index altogether.
I don't know how accurate this is, and I'm sure you would know this anyway, but if it helps you find it faster I thought I'd supply it.
I'll take a look at it when I have a chance; it definitely could be a connector related issue.
Can you confirm that the issue does not occur if you remove Excavated Variants, and also that the issue still occurs if you remove Connector and all fabric mods?
I've confirmed that it doesn't occur if I remove Excavated Variants (I didn't even remove Dynamic Asset Generator).
Unfortunately due to how modded the server is and it being a community server I'm unable to just wholesale take out all the Connector and Fabric Mods. It is only EV that has caused this issue, and all the stack trace is pointing towards EV.
The stack trace does not, in fact, clearly point towards Excavated Variants, hence why I need a test without Connector. I will try to follow up with this sometime later; it may be a good while before I have the time to recreate your whole mod list minus connector and try to reproduce this, however.