Excavated Variants

Excavated Variants

3M Downloads

[BUG] priority config does not work (also, better nether's lapis should be separate from vanilla)

qtow opened this issue ยท 4 comments

commented

What went wrong?

The logic at ConfigResource.java:30 is backwards - you want filter to keep things not contained in the original list. You might also consider using Stream#concat and Stream#disjoint, a bit overkill but perhaps more expressive.

I found this because BetterNether's lapis ore is becoming the "default" lapis ore, which makes all of the non-vanilla variants drop BetterNether's Lapis Pile's, and also require a diamond pickaxe to mine. I think that BetterNether's lapis should probably be a distinct ore from vanilla lapis, just like vanilla nether gold is distinct from overworld gold.

Also, they should all be called Lapis Lazuli Ore, not Lapis Ore.

Platform

Quilt

Version

1.0.3

Logs and Screenshots

No response

commented

I'll fix that in the next release; lapis ore is named that way since the names get really large with stone names otherwise.

commented

Should the list on ExcavatedVariants:128 contain lapis as well?

commented

Fixed in recent commits; fix will be included in the next version

commented

Fixed in upcoming 1.19.3 release; waiting on MinecraftForge/MinecraftForge#9208