Exchangers

Exchangers

26M Downloads

Strange Interaction: FactionMod and Exchangers!

Akitori opened this issue ยท 9 comments

commented

To summarize the issue (grabbed version 1.12.2-2.6), decided to try and test it on a faction based server. (Mainly because you may want to switch from obsidian walls to normal walls once you're certain threats are gone)

I tried testing on the edge of claimed land and got this weird bug.

https://youtu.be/AvLs45PitBY"

dunno if i should pester factionmod or you first, as its clearly a interaction between the two of them.

commented

I've looked into the Faction Mod a bit, seems like there's no ways of fixing it on my side as it's a very complicated problems and weird interactions between mods. I suggest you to report this bug to the Faction Mod issue tracker instead. But from my point of view of seeing this, if people really wants to cheat / exploit anything, they might as well go into Creative mode.

commented

So i talked to the modmaker of factions and he said the following.

"I can't fix it by my side (the only thing my mod does is canceling Forge events when a player places/breaks blocks). It's really weird, because, if you look into Exchangers mod's code, blocks should be replaced correctly. The only thing I could notice is the mod author doesn't fire any Forge event when the player replace blocks, so we can't cancel it. A BreakEvent or a PlaceEvent could maybe be fired here : https://github.com/JackyyTV/Exchangers/blob/dev-1.12/src/main/java/jackyy/exchangers/handler/ExchangerHandler.java#L196"

commented

Hmm, in that case, I shall reopen this issue until I get it fixed.

commented

Can you test this new version for me @Akitori? Hopefully should fix the problems.
Download link: Click me

commented

Heya! @JackyyTV I've got the newest version and i did a video

https://youtu.be/Vn49PfBx1Rw

New bug popped up. So now i can't magically mass dupe my diamonds/blocks, but i can however affect faction land now.

commented

Hmm that's weird, the exchange event was being cancelled but apparently it still exchanged the blocks...
Gonna have to fix that.

commented

Alright @Akitori, here's a new version, hopefully should have fixed that weird bug. Let me know if more weird things happens again.

commented

Howdy!
https://youtu.be/-dXoACCjIIE
Mission sorta accomplished!

commented

Good to see the bug is finally being fixed! Although I'll have to fix the issue you've mentioned in the video, so I'll leave this issue open for now.