Ex Nihilo: Sequentia

Ex Nihilo: Sequentia

9M Downloads

[Request] Add compability tags please.

adamkad1 opened this issue · 8 comments

commented

Is there an existing suggestion for this?

  • I have searched the existing suggestions

Feature Description

I know there are compability mods that havent been updated to 1.19 yet but with proper tags they probably wouldnt be neccesary.

Provided Benefit

Proper tags would make extra mods unnecessary. (though to be honest, the ores that are useless without other mods should just be shifted away from the main mod.)

Additional Context

javaw_YGtEllK39B
javaw_gC5HeLzXcO
The tags of a working ingot and exnihilo ingot.
A forge:ingots/(materialname) tag usually makes ingots useable with most recipes, without requiring a secondary compability mod
Example:
javaw_ZJp2lWPcnC

commented

can confirm, this line has nothing to create those tags. in 1.18 they exist:

private void registerIngot(@NotNull Ore ore, @NotNull ExNihiloTags.OreTag tags) {}

commented

Also I dunno if I should make a new post but it seems minor enough. Its aluminium, not aluminum.

commented

Also I dunno if I should make a new post but it seems minor enough. Its aluminium, not aluminum.

In America it is aluminum

commented

Also I dunno if I should make a new post but it seems minor enough. Its aluminium, not aluminum.

In America it is aluminum

TIL

commented

According to this

public static ResourceLocation getOre(@Nonnull final String ore) {
return forgeLoc("ores/" + ore);
}
the raw ores are incorrectly tagged, pointing to tag forge:ores instead of forge:raw_materials
Nuggets are also untagged

I made a KubeJS script to fix this until the fix is ​​done

I could have done it, but I can't compile the code to test it, it always gives CraftTweaker error on game startup

KubeJS script
ServerEvents.tags('item', event => {
    const raw_ores = event.get('forge:ores').getObjectIds();
    const raw_to_fix = Ingredient.of(/.*exnihilosequentia:raw_.*/);

    raw_ores.forEach(ore => {
        const ore_str = ore.toString();
        if (raw_to_fix.test(ore)) {

            event.removeAllTagsFrom(ore_str);

            event.add('forge:raw_materials', ore_str);

            const material = ore_str.substring(ore_str.lastIndexOf("_") + 1);

            event.add('forge:raw_materials/' + material, ore_str);

            const nugget = `exnihilosequentia:${material}_nugget`

            event.add('forge:nuggets', nugget);

            event.add('forge:nuggets/' + material, nugget);
        }
    })
})

This removes the tag forge:ores and put forge:raw_materials

commented

Did not know that forge added a raw ores tag. I will update.

commented

Fixed in latest version

commented

Hello, if changes return forgeLoc("ores/" + ore); to return forgeLoc("raw_materials/" + ore);, will it worked?.