Versions

Minecraft Version: 1.11.2
Extended Days Version: 0.2.3
Silent Lib Version: 2.2.6
Galacticraft version: 4.0.1.174

Expected behavior

• Player successfully arrive on Space Station

Actual behaviour

• Game crashes when player arrive on Space Station
  Crash Report

Steps to reproduce the problem

1. Add Extended days and Galacticraft in mod pack
2. Fly on Space Station
3. ...
4. Profit

Also see Galacticraft#3379

Hi, I'm one of the Galacticraft devs. The problem here is that Extended Days is overriding / replacing our intended SkyRenderer for this non-vanilla dimension. Our code creates a custom SkyRenderer for each of our non-vanilla dimensions.

To fix this you can maybe do one of the following things:

1. (Best) Do not override the SkyRenderer if it is already not the vanilla Minecraft SkyRenderer
2. Provide an API so that another mod's WorldProvider class can flag to Extended Days not to override the SkyRenderer in this dimension
3. Provide a config to enable/disable the Sky Renderer Override on a per dimension basis (with a list of dimension numbers)

OK, thanks. I should have been checking that I can actually cast the class. I'll add a blacklist to the config as well. And I apologize for letting this sit so long, no idea how I missed this. (edit) Will implement 1.12.2 fix first, then 1.11.2.

No worries :) Happy that you will be fixing it at all!

BUT: it's our class cast which is failing here. The real concern is that you are overriding our skyProvider at all, we need to have total control over the skyProvider in all our space dimensions otherwise they are going to look mighty strange, with blue skies etc in space...

For your blacklist our default dimension IDs are -28 through to -32. But those can sometimes be different if players change our config. And also any unused positive dimension ID from 2 onwards can be created dynamically as a Galacticraft space dimension if a player creates their own space station. (One dimension like this can be created per player, on a multiplayer server.) And Galacticraft third party add-ons add even more planets with negative dimension IDs. So it could end up being quite a lot of dimension IDs to configure.

Can I suggest it might be better if you check the WorldProvider class and see if it's a vanilla WorldProviderSurface - or call WorldProvider.getDimensionType and see if that's DimensionType.OVERWORLD? This check should be enough for you to avoid all the Galacticraft dimensions (and it's add-ons) and should be future proof, without players needing to set up configs correctly.

Fixed in 0.2.5