Extra Alchemy

Extra Alchemy

13M Downloads

1.16.1 Can't open Potion Bag GUI on Server

kingofrunes opened this issue ยท 10 comments

commented

Having a weird issue where when I shift right click the Potion Bag I can't open it on the server. It works on Single Player.

Not sure if this is related, but after I tried to open it and logged out and back into the server, I ran into this error that required a server reboot: "Internal Exception: io.netty.handler.code.DecoderException: Badly compressed packet - size of 2308003 is larger than protocol maxium of 2097152". Happened twice, each time after I attempt to open the potion bag several times. Haven't seen the error come up since.

Mods:
Extra Alchemy 1.2.1
Fabric 0.16.2? Hard to tell. Fabric Loader is 0.9.1+build.205. The log spits out [email protected]+build.385-1.16.1

commented

Update. Had the server admin try and replicate and these are the steps they did.

  1. Attempt to open bag, nothing
  2. Log out, log back in
  3. Attempt to open bag, worked no issue.
  4. Log out, log back in (to test the bad packet error. No error.

I replicated the same process as admin and was able to replicate his behavior. Really weird. Maybe it's when I was attempting repeatedly to open it when it wasn't working is what was causing the bad packet error

commented

Can you include a link to the pastebin pages with the server and client log files? I need to check if something useful pops up there.
I also need the server and client mod lists

commented

Also, please next time follow the bug report template, it includes everything I need to know

commented

[Info: 2020-08-31 12:12:56.7915676: GameCallbacks.cpp(163)] Game/net.minecraft.class_3929 (main) Warn Trying to open invalid screen with name: Potion Bag

That's what I see client side.

This is the client side mods
Loading 162 mods: [email protected], [email protected]+3fa9f7c5b0, [email protected]+1.16.1, [email protected], [email protected]+build.205, [email protected], [email protected]+1.16.1, sleepvote@${version}, [email protected], [email protected], [email protected]+a71b305302, libgamerule@${version}, [email protected], [email protected], [email protected]+fe81e12502, [email protected], [email protected], [email protected], [email protected]+12a8474cb0, [email protected]+build.64, [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]+c6a8ea8902, [email protected], [email protected], [email protected]+build.385-1.16.1, respawnablepets@4, [email protected]+e00ecb5f02, [email protected], [email protected]+1.16.1, [email protected]+build.88, [email protected], [email protected]+97324d1102, [email protected]+build.30, [email protected]+mc1.16.1, [email protected], [email protected], [email protected]+build.7, [email protected], [email protected]+55e0cc5f02, [email protected], [email protected], [email protected], [email protected], [email protected]+059ea86602, [email protected]+7066030fb0, [email protected]+b7f9825d02, [email protected], [email protected], [email protected], [email protected]+build.1, [email protected], [email protected]+mc1.16.1, [email protected]+f404f3be02, [email protected], [email protected], [email protected]+f41e209802, [email protected], [email protected], [email protected], [email protected]+1.16-pre2, [email protected], [email protected], [email protected], [email protected], [email protected]+52d3083602, [email protected]+7dba2d6c02, [email protected]+1.16.1, [email protected], [email protected], [email protected]+b764ce9902, [email protected]+438f963602, [email protected]+dfdb52d602, [email protected], [email protected]+1.16.1, [email protected], [email protected]+eae12eb802, [email protected]+1.15.2, [email protected], [email protected]+build.50, [email protected]+1.16-pre2, [email protected], [email protected], [email protected], [email protected], [email protected]+045df74f02, [email protected]+a2d21ddd02, [email protected], [email protected]+b7f9825d02, [email protected], [email protected]+build.35, [email protected], [email protected], [email protected]+eae12eb802, [email protected], [email protected]+b7084faa02, [email protected], [email protected], [email protected], [email protected]+e83e061c02, [email protected], [email protected], [email protected]+5a0f9a6002, [email protected], [email protected], [email protected]+386eb69e02, [email protected], [email protected]+0a6f2a7002, [email protected]+1.16.1, [email protected], [email protected]+build.31, [email protected], [email protected]+minecraft-1.16.1, [email protected], [email protected], [email protected]+b50ffc7b02, [email protected], [email protected], [email protected]+j1.2.0, [email protected]+5ce5339802, [email protected], [email protected], [email protected]+1.16-rc1, [email protected]+34d6c87102, [email protected], [email protected], [email protected]+16acbe5b02, [email protected]+build.10, [email protected], [email protected]+1.16.1, [email protected], [email protected], [email protected]+5341049002, [email protected]+346247d702, [email protected], [email protected], [email protected], [email protected]+059ea86602, [email protected], [email protected]+a4c57d8e02, blue_endless_jankson@+, [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]+build.43-1.16.1, [email protected]+16acbe5b02, [email protected], [email protected], [email protected], [email protected]+a2d21ddd02, [email protected]

I asked the server admin for the info from the server, see if there's anything there.

Mod list from server.
Adorn-1.10.0+1.16.1.jar
Controlling-For-Fabric-1.1.2.jar
Harvest-fabric-1.16.1-1.2.12-26.jar
Hwyla-fabric-1.16.1-1.9.22-75.jar
Patchouli-1.16-39-FABRIC.jar
RebornCore-1.16-4.3.4+build.64.jar
RingOfAttraction-Fabric_1.16.1-1.0.21.jar
RoughlyEnoughItems-4.10.5.jar
Soulbound-fabric-1.16.1-1.1.1-7.jar
TechReborn-1.16-3.4.5+build.88.jar
Towelette-4.1.5+1.16.1.jar
WhereIsIt-1.16.1-1.8.1.jar
appleskin-mc1.16-fabric-1.0.11.jar
artofalchemy-1.0.0-rc2+1.16.1.jar
astromine-1.5.2+fabric-1.16.1.jar
blockus-1.6.2.jar
campanion-1.1.13+build.35.jar
cinderscapes-1.0.7+build.43-1.16.1.jar
cloth-api-1.0.8.jar
columns-1.1.0.jar
config-2-4.6.0.jar
curioofundying-fabric-1.16.1-1.0.jar
curios-fabric-1.16.1-0.5.jar
data-loader-2.1.0+mc1.16.1.jar
enderlift-1.0.7.jar
expandedstorage-5.3.16+1.16.jar
extraalchemy-fabric-1.16.1-1.2.1+build16.jar
extrapieces-2.9.0+1.16.1.jar
fabric-api-0.16.2+build.385-1.16.1.jar
fabric-language-kotlin-1.3.71+build.1.jar
fatxporbs-0.0.7+1.16-rc1.jar
glassential-fabric-1.16.1-1.1.4.jar
gravestones-1.4.0.jar
inmis-1.2.0-1.16.1.jar
iron-jetpacks-0.2.5.jar
leaf-decay-1.2.0-1.16.1.jar
leafmealone-2.1.jar
linkedstorage-1.3.5-1.16.jar
lithium-fabric-mc1.16.1-0.5.1.jar
notenoughcrashes-2.1.3+1.16.1.jar
phosphor-fabric-mc1.16.1-0.6.0+build.7.jar
quickshulker-1.1.5-1.16.jar
rer-2.0.2.jar
respawnablepets-4.jar
shulkerboxtooltip-2.1.0+1.16.1.jar
simpledrawers-1.8.0-1.16.1.jar
simpleteleporters-2.2.0.jar
sleepvote-1.8+1.16.1.jar
slotlink-1.0.3+minecraft-1.16.1.jar
staffofbuilding-1.2.0-1.16.jar
terrestria-2.0.4+build.50.jar
tinyfuel-fabric-0.3.0.jar
wolves-with-armor-1.5.1-1.16.1.jar
ynet-0.2.0+1.16.1.jar

commented

Nothing useful server side from the logs. Only thing is the client which is most likely the source of the issue. The [Info: 2020-08-31 12:12:56.7915676: GameCallbacks.cpp(163)] Game/net.minecraft.class_3929 (main) Warn Trying to open invalid screen with name: Potion Bag message.

commented

Trying to open invalid screen with name: Potion Bag is printed by net.minecraft.client.gui.screen.Screens.open(@Nullable ContainerType<T> type, MinecraftClient client, int id, Text name) because the ContainerType variable is null. Its value comes from OpenContainerS2CPacket:

   public ContainerType<?> getContainerType() {
      return (ContainerType)Registry.CONTAINER.get(this.containerId);
   }

Looks like the container is not registered properly on the client side. But I cannot spot any problem in the usage of Fabric Gui API in this mod.

commented

The fix works. In 1.16.1, the problem can be fixed by adding a line:

zabi.minecraft.extraalchemy.screen.ModScreenHandlerTypes.POTION_BAG.toString();

at the end of zabi.minecraft.extraalchemy.ExtraAlchemy.onInitialize().

I'm 99% sure this is a Fabric API bug. I will start an issue on their repo.

Actually this might not be a bug. The problem is caused by the way we use the API.

commented

No, it is not an api bug. It was extra alchemy that had the registration happen at class init instead of mod init. By adding that line you load the class at the right moment instead of at world join.
That confirms the fix I pushed yesterday

commented

Anyway, it will be fixed in the next release for 1.16.2

commented

Fix available on curseforge