ExtraSounds

ExtraSounds

3M Downloads

Crashing on launch with OptiFine.

witheredwojak opened this issue · 10 comments

commented

Minecraft: 1.19 & Fabric 0.14.8
Mod: 2.3.1

Details

Game crashing on launch when using ExtraSound & OptiFine+OptiFabric.
OptiFine version: preview_OptiFine_1.19_HD_U_H8_pre10
OptiFabric version: 1.13.5

Link to full log: https://paste.ee/p/wc5mo

commented

The same issue for me : (

commented

I am having the same issue even in 1.17.1

commented

Can confirm this is a issue. Having the same crash in similar configurations. Hope this gets fixed next update if possible.

commented

To clarify, this crash only occurs with the following version combinations:

  • Minecraft 1.19.2, 1.19.1, and 1.19 + ExtraSounds 2.3.1 + OptiFabric 1.13.10
  • Minecraft 1.17.1 + ExtraSounds 2.2.1 + OptiFabric 1.13.10

All other versions (1.18.2, 1.18.1, 1.16.5) are unaffected, and work fine.

If I can find the time to do so sometime later, I'll try and see if I can figure out what exactly is causing the crash to occur.


※ EDIT: Seems like the issue lies in the SoundCategories library that ExtraSounds is using.

commented

still happening with me (using optifabric 1.13.16)

commented

Tried to search for somethig in the logs

the main thing i found was only the refmap
soundcategories.mixins.json:GameOptionsMixin from mod soundcategories failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap soundcategories-refmap.json

commented

The cause for the crash (at least as far as I can see) is the game options mixin failing, because Optifine mutilates the game options screen class. If that's the only issue preventing Optifine support, v3 will fully support it - you'll most likely have to open the volume settings through mod menu or some other place as a workaround.
However, if there's any further issue with it, I will completely block Optifine and it will forever be unsupported. I do not want the mod to break your Minecraft setups with every other Optifine release.

commented

is there any update on the optifine fix?

commented

Just ran into the same issue while putting together a 1.19.2 modpack; has there been a work around found out? If so can someone please post a guide in this thread on how to fix it.

commented

Hey folks, I keep you waiting.

I usually use Iris and had no connection to OptiFine, so I think I can not provide ongoing support, will be one time. If you still want, I’d like to help as much as I can. I found a workaround about this and works fine on my instance with OptiFine.

2023-03-18_22 45 56

I will publish them on my maven.

I am going to limit this to optifabric compatibility as backporting is really too hard for me. Also I think this issue shouldn’t be discussed here, please visit issue board on my fork.