Extreme sound muffler (Forge)

Extreme sound muffler (Forge)

13M Downloads

Minecart sounds are not mufflable

henkelmax opened this issue ยท 2 comments

commented

Versions
Indicate the versions for:

  • Extreme sound muffler 3.9 and 3.10
  • Forge 36.1.0

Describe the bug
Minecart sounds are not mufflable.

To Reproduce
Steps to reproduce the behavior:

  1. Open the sound muffler GUI
  2. Change the volume of entity.minecart.riding:minecraft and entity.minecart.inside:minecraft to something like 90%
  3. No minecart sound plays at all

Expected behavior
The sound to be playing with 90% volume

Screenshots or Crashlog
image

Additional context
I think the problem is because these sounds are TickableSound sounds.

Another problem is muffling the sound of cars from the Ultimate Car Mod or planes of the Ultimate Plane Mod.
When reducing the volume of these sounds, it causes the sound to be stacked infinitely.

2021-05-12.18-28-56.mp4
commented

Yes I am aware of this problem but I dunno how to fix it. My hopes are that I'll find a solution with mixins but I haven't had time to implement that yet :c

I created a PR that fixes the tickable sound issues with mixins. If you have any questions about it, let me know :)

commented

Yes I am aware of this problem but I dunno how to fix it. My hopes are that I'll find a solution with mixins but I haven't had time to implement that yet :c