Extreme sound muffler - (Neo)Forge

Extreme sound muffler - (Neo)Forge

49M Downloads

Mixin conflict with Dynamic Surroundings

Renektoff opened this issue ยท 1 comments

commented

Extreme sound muffler version

3.48.3

Forge / Fabric / NeoForge version

NeoForge 1.21.1

Additional mod(s) version (If bug is due incompatibility)

Dynamic Surroundings latest version on NeoForge - 0.4.2 as of writing this.

Describe the bug

Hey :) I tend to add a bunch of sound mods to my modpacks and I noticed an incompatibility between Extreme Sound Muffler and Dynamic Surroundings. When I have both installed, it seems Dynamic Surroundings has a mixin that touches the same piece of code that ESM needs. When I load the game with both available, the recent sounds menu is blank and muffling doesn't work, no matter which sounds I toggle off. I disabled Dynamic Surroundings and ESM started working as expected.

Note that I tried it in a modpack with a bunch of other mods so I haven't tested it in isolation but it seems like the interaction between only those 2 mods is causing this. Let me know if you can't reproduce or something and I can dig up a full mod list :)

Steps to reproduce

  1. Launch a game with both ESM and Dynamic Surroundings.
  2. ESM's recent sounds screen is empty / muffling doesn't work.
  3. Disable Dynamic Surroundings and ESM works as expected.

Crashlog

No response

Additional context

No response

commented

yes, this always was a problem with DS, they have change a lot of things from the sound engine last time I looked at it, and they had their own muffle system to.. curseforge should mark it as incompatible.. and there's no much I can do as far as I know.