Fabric API

Fabric API

106M Downloads

Trade helper bugs

i509VCB opened this issue ยท 2 comments

commented

The way fabric api works on trades, the trade reloading logic won't work.

The trade reloading logic is a bit too mod load order dependent. Take this example:

Mod registers via helper
Another mod registers directly to offer map
A third mod registers but via helper
2nd mod's trades drop.

This means depreciating the existing api regarding reloading and depreciating the registration consumer.

This should just become a [level, profession] = trade.

I originally intended to add that api to allow for data reloadable trades but it wont really work.

commented

Why not just do it in like two batches, one for addition and one extra round for removal

commented

Fixed via #1430, please reopen if issues persist.