Recent fabric-networking-v0 version causing mixin apply errors when installed with fabric-networking
sargunv opened this issue · 6 comments
I'm still investigating CottonMC/SkillCheck#19, but I suspect this is a Fabric API issue so I'm reporting here.
Mixin apply errors on launch: https://paste.ee/p/bNi9t
Error happens with fabric-networking-v0-0.1.2+200eb5c2
Works fine with fabric-networking-v0-0.1.0+f1618918
Narrowed it down to somewhere between 57f0d19 (henceforth A) and 945f265 (henceforth B). Jar fabric-networking-v0 from commit A is good, while commit B triggers the crash (when installed alongside fabric-networking 93af775). Since A is the parent of B, the problem must have been introduced in B. Looking at B, the only real change I see is a mappings update. Perhaps this is triggering some mappings related issue in loom or loader?
One thing that mystifies me is @el0c's claim that this only appears when the mod count is under 50. So far I've only attempted to reproduce this in a minimal setting.
My best guess as to how this could be happening is that one mod's refmap is somehow interfering with another, and since the Screen class moved packages in the mappings between commit A and B, that interference caused the mixin to fail to apply.
To test this theory, I modified the modids of fabric-networking-v0 at commit A and B so I could load them at the same time. Since A's refmap is the same as fabric-networking's refmap, I expected A' and B' installed together to also reproduce the error. However, the error did not occur. So, there must be some other trigger than just two mod refmaps referring to the same intermediary name with different yarn names.
Thanks! I've seen this happen in log messages, but usually when this happens mods are faulty. Dunno how as well, guess it's not a problem.
Just tested, no crash on MC 1.14.4 with [email protected]+93af775a and [email protected]+f6e5d2dc42. I guess it no longer happens, unless I forgot how to reproduce.