Fabric API

Fabric API

106M Downloads

Wrong Logic In GlobalReceiverRegistry

warjort opened this issue ยท 6 comments

commented

The check here is wrong:

See:#2358
It should be if (replaced). This wasn't noticed before because most people register their receivers in the mod initialiser.

commented

FYI, I invited you to the team a few days ago, I think you need to accept it somewhere. Possibly check your emails?

commented

Ok done. :-)

commented

I don't know who wrote this code, but the original author is incorrectly using write lock in multiple occasions when a simple read lock suffices.

commented

Hi @warjort sorry for hyjacking your issue as I haven't been able to get in contact with you by any other means.

As you have been very active and helpful on the issues and discussion pages we were just wondering if you would like to join the triage team. This would provide you with some extra magical powers, such as being able to help moderate and manage the issues/discussions.

There is no commitment to be made, but I just wanted to confirm it with you first.

Thanks ๐Ÿ‘

commented

Ok with me, but I probably won't use any special powers, except maybe the support tag? :-)

commented

Awesome, thanks. Thats basically the extent of the magical powers ๐Ÿ˜†