Fabric API

Fabric API

Mods
106M Downloads

Disconnected screen scissoring is incorrect on high-resolution displays

haykam821 opened this issue ยท 0 comments

commented

On Windows systems, the disconnect screen has correct scissoring:

Windows disconnect screen example

However, on macOS systems with Retina displays, the disconnect screen cuts off the bottom of text:

macOS Retina disconnect screen example

The related scissoring code does not use the getFramebufferHeight and getFramebufferWidth methods, causing this issue:

fabric/fabric-networking-api-v1/src/client/java/net/fabricmc/fabric/mixin/networking/client/DisconnectedScreenMixin.java

Lines 67 to 70 in b20e333

double scale = client.getWindow().getScaleFactor();
RenderSystem.enableScissor(0, (int) (y * scale), (int) (width * scale), (int) (reasonHeight * scale));
instance.drawCenterWithShadow(matrixStack, x, y - scroll);
RenderSystem.disableScissor();

Relates to CottonMC/LibGui#114