Fabric API

Fabric API

Mods
106M Downloads

Standardize using one logger factory method

haykam821 opened this issue ยท 0 comments

commented

Currently, a mix of SLF4J's LoggerFactory.getLogger and Mojang's LogUtils.getLogger are used within Fabric API to construct loggers. While most loggers are constructed using the former method, the latter method seems to be used only three times:

fabric/fabric-biome-api-v1/src/main/java/net/fabricmc/fabric/impl/biome/NetherBiomeData.java

Line 51 in 2dae9cf

private static final Logger LOGGER = LogUtils.getLogger();

fabric/fabric-networking-api-v1/src/client/java/net/fabricmc/fabric/impl/networking/client/ClientPlayNetworkAddon.java

Line 45 in 2dae9cf

private static final Logger LOGGER = LogUtils.getLogger();

fabric/fabric-registry-sync-v0/src/testmod/java/net/fabricmc/fabric/test/registry/sync/RegistrySyncTest.java

Line 52 in 2dae9cf

private static final Logger LOGGER = LogUtils.getLogger();

Ideally, Fabric API should stick to using one of these methods. The least impactful refactor would to replace LogUtils.getLogger usage with LoggerFactory.getLogger.