Fabric API

The deprecated VillagerTypeHelper.register method uses new Identifier(id.toString()) rather than id:

fabric/fabric-object-builder-api-v1/src/main/java/net/fabricmc/fabric/api/object/builder/v1/villager/VillagerTypeHelper.java

Lines 57 to 60 in 65c120e

    
           public static VillagerType register(Identifier id) { 
        
           	Objects.requireNonNull(id, "Id of villager type cannot be null"); 
        
           	return Registry.register(Registries.VILLAGER_TYPE, new Identifier(id.toString()), new VillagerType(id.toString())); 
        
           }

There shouldn't be any observable difference between the two arguments, but the behavior is a bit silly and seems to have been introduced in 1e232e1.

Its almost not worth the effort to fix this.

	public static VillagerType register(Identifier id) {
	Objects.requireNonNull(id, "Id of villager type cannot be null");
	return Registry.register(Registries.VILLAGER_TYPE, new Identifier(id.toString()), new VillagerType(id.toString()));
	}

Share to