Fabric API

108M DownloadsUpdated 3 days agoCreated 6 years ago

Crash when loading void superflat with registered biome modifications

Oliver-makes-code opened this issue 7 months ago · 4 comments

Oliver-makes-code commented 7 months ago

Crash log: https://mclo.gs/lH6dDg6

Minimal reproduction repository: https://github.com/Oliver-makes-code/biome-modification-crash

Reproduction steps:

Run the client with the reproduction repository
Create a new void superflat world
Crash

Oliver-makes-code commented 7 months ago

I'm investigating this issue further

Oliver-makes-code commented 7 months ago

It appears I had the reproduction wrong, I amended that.

Oliver-makes-code commented 7 months ago

fabric/fabric-biome-api-v1/src/main/java/net/fabricmc/fabric/impl/biome/modification/BiomeModificationImpl.java

Line 160 in a704f5c

    
           dimensionOptions.chunkGenerator().indexedFeaturesListSupplier = Suppliers.memoize(

This could be where the issue is originating

apple502j commented 7 months ago

Pro tip: always test superflat worlds, even if you're testing Biome API...