Fabric API

Fabric API

108M Downloads

Model offset is ignored by Indigo in non-terrain block rendering

PepperCode1 opened this issue ยท 4 comments

commented

This is an extremely old bug. I cannot identify if it was present in the original FRAPI/Indigo changes since I am not familiar with 1.15 rendering code, but I am quite sure it affects all versions 1.16 and newer, at least.

I plan to submit a pull request soon to fix this.

commented

It looks like model offsets for terrain rendering were also broken at some point but then fixed by this pull request. I assume offsets for non-terrain rendering have been broken since then as well, but no one noticed until now.

commented

this problem doesn't seem to have been solved yet
these 2 Pull Requests (#3799, comp500/Indium#295) arose due to a report of an incompatibility report between the A Good Place mod and Continuity (PepperCode1/Continuity#420), where the A Good Place mod adds animations when placing blocks, but when using any Connected Textures resourcepack the animations present a problem, because the block appears in place before the animation is finished.

Continuity.mp4

this problem only happens when Sodium and Indium are also present, in the video below im not using these mods

Without.Sodium.And.Indium.mp4

I've updated all the mods where the fix has already been implemented (Indium and Fabric API)

Mods links -
https://modrinth.com/mod/a-good-place
https://modrinth.com/mod/continuity
Fabric 1.20.1
Fabric Loader 0.15.11

commented

This issue as described by the title and description is definitely 100% fixed, so it does not make sense to discuss unrelated issues here. Use the issue trackers for those mods to report remaining incompatibilities.

commented

ok, sorry
i only commented here because you said

Use FabricMC/fabric#3798 to track this issue since it's not a Continuity issue.