Add `c:enchantable` parent item tag for minecraft's enchantable tags
TelepathicGrunt opened this issue · 2 comments
If you check vanilla, there is no minecraft:enchantable tag.
https://github.com/misode/mcmeta/tree/data-json/data/minecraft/tags/item
It would make sense for us to add a parent tag for that under c that includes all the tags under enchantable folder. This would allow mods like Soulbound enchantment to apply to any item that is in any vanilla enchantable tag. And mods would add their enchantable items to this c tag if they don't add to a vanilla tag.
Good or no?
Someone suggested we do minecraft:enchantable instead but not sure how modloaders feel about making a new Mc tag neoforged/NeoForge#1325 (comment)
Closing as this already exists. I'm just an idiot that forgot we added it already lol
https://github.com/FabricMC/fabric/blob/1.21/fabric-convention-tags-v2/src/generated/resources/data/c/tags/item/enchantables.json