Fabric API

Fabric API

Mods
106M Downloads

`c:is_cold` tag is missing `c:is_cold/end`

PaintNinja opened this issue ยท 0 comments

commented

While working on Forge's implementation of the de-facto partial c: tags across loaders, we noticed a discrepancy between Neo and Fabric for the c:is_cold tag and believe it may be an oversight. MinecraftForge/MinecraftForge#9955 (comment)

For c:is_hot, it contains the c:is_hot/overworld and c:is_hot/nether variants:

fabric/fabric-convention-tags-v2/src/datagen/java/net/fabricmc/fabric/impl/tag/convention/datagen/generators/BiomeTagGenerator.java

Lines 173 to 175 in 5763228

getOrCreateTagBuilder(ConventionalBiomeTags.IS_COLD)
.addTag(ConventionalBiomeTags.IS_COLD_OVERWORLD);

However, c:is_cold does not contain the c:is_cold/end variant:

fabric/fabric-convention-tags-v2/src/datagen/java/net/fabricmc/fabric/impl/tag/convention/datagen/generators/BiomeTagGenerator.java

Lines 212 to 215 in 5763228

getOrCreateTagBuilder(ConventionalBiomeTags.IS_HOT)
.addTag(ConventionalBiomeTags.IS_HOT_OVERWORLD)
.addTag(ConventionalBiomeTags.IS_HOT_NETHER);