Fabric API

Fabric API

152M Downloads

Stems/Hyphae Convetion Tags

solonovamax opened this issue ยท 4 comments

commented

I think it would be nice to have a stems convention tag.
Currently, there is #c:stripped_logs and #c:stripped_woods, which include minecraft:stripped_crimson_stem & minecraft:stripped_warped_stem and minecraft:stripped_crimson_hyphae & minecraft:stripped_warped_hyphae, respectively, in them.

I think that in addition to that, there should be 4 new tags:

  • #c:stems:
    • minecraft:crimson_stem
    • minecraft:warped_stem
    • minecraft:stripped_crimson_stem
    • minecraft:stripped_warped_stem
  • #c:stripped_stems:
    • minecraft:stripped_crimson_stem
    • minecraft:stripped_warped_stem
  • #c:hyphae:
    • minecraft:crimson_hyphae
    • minecraft:warped_hyphae
    • minecraft:stripped_crimson_hyphae
    • minecraft:stripped_warped_hyphae
  • #c:stripped_hyphae:
    • minecraft:stripped_crimson_hyphae
    • minecraft:stripped_warped_hyphae
commented

Just wondering, what is the specific use case you have that need these tags?

commented

Just wondering, what is the specific use case you have that need these tags?

I'm sort of iffy on the exact reason I created this as it was some time ago, but I believe the reason I wanted it was for being able to have a better way to isolate logs from stems/hyphae for datagen stuff:

https://github.com/solonovamax/BetterRecipes/blob/2f52d32d85a809753f83e8c5d7cd6d9cc80ce50d/src/datagen/kotlin/gay/solonovamax/betterrecipes/datagen/recipe/BetterRecipesRecipeGenerator.kt#L1025-L1047

though honestly I'm not fully sure that was it and I very well could be misremembering.

commented

Hmm. Lets leave this open to see if anyone has more use cases or demand for this

An idea is changing the stripped tags completely to this but that would be a larger change that people would need to migrate to using.
c:stripped/wood c:stripped/logs c:stripped/stems c:stripped/hyphae

commented

Hmm. Lets leave this open to see if anyone has more use cases or demand for this

An idea is changing the stripped tags completely to this but that would be a larger change that people would need to migrate to using. c:stripped/wood c:stripped/logs c:stripped/stems c:stripped/hyphae

yeah, I was more thinking just adding new tags which contain the stems/hyphae, and not modifying the existing ones.

also currently there aren't any tags for logs which occur specifically in the nether ("nether logs"), those might be useful to people. as, people may choose to make mods which add nether logs which are not necessarily stems/hyphae, so the set of all nether logs contains but isn't equal to the set of all stems/hyphae.