Fabric API

Fabric API

106M Downloads

Expose InternalBiomeUtils.transformBiome

Juuxel opened this issue · 6 comments

commented

transformBiome can be used by dimension mods for transforming modded biomes into their variants, which is done in the SetBaseBiomesLayer mixin in the biome API. (SetBaseBiomesLayer places all registered continental biomes, so I can't use that directly.)

commented

Not applicable for 1.18+

commented

@valoeghese should speak given he wrote the biome api.

commented

I didn’t write it by myself, coderbot and prospector also contributed

commented

Anyway, we should expose it through a method in FabricBiomes, I think (since that’s the class for stuff not pertaining to a specific dimension). Possibly FabricBiomes#transformBiome or FabricBiomes#transformBiomeVariant?

commented

Yeah, I think a method in FabricBiomes would be good, though biome variants are registered in OverworldBiomes#addBiomeVariant. Should we move that to FabricBiomes? (It only applies to dimensions that use either the overworld base biome layer or transform the biomes themselves)

commented

I think it makes sense to keep it all in OverworldBiomes because these biomes only spawn in the Overworld by default or Overworld-like biomes.