Fabric API

Fabric API

152M Downloads

[1.21.9] Redesign and reimplement `WorldRenderEvents`

Closed this issue · 8 comments

commented

This API was removed during the 1.21.9 port due to significant and fundamental changes to vanilla rendering code.

commented

If I may ask, what issues were present in the WorldRenderEvents that necessitated them being temporarily removed?
Issue 4868 and pull 4875 mention there were problems but not what the problems were.

Either way I patiently await their re-introduction so I can update Distant Horizons.

commented

If I may ask, what issues were present in the WorldRenderEvents that necessitated them being temporarily removed? Issue 4868 and pull 4875 mention there were problems but not what the problems were.

Either way I patiently await their re-introduction so I can update Distant Horizons.

Other than removing the old render context and replacing it with vanilla's render state nobody seems to know whats needed. A lot of people have made their own mixin but provided no suggestions for what we should do. Everyone keeps asking for something but dont seem to know what they actually want. Unfortunately I have no clue whats going on with rendering related things so cannot really offer any advice or solve the problem. I wish I could help get this done yesterday, but if I do it we would just end up with something worse than before. Someone who has more rendering brain cells than me needs to make a PR and then get other people to review it.

commented

owe so do we have to wait for a new 1.21,9 fabric api to come out

commented

owe so do we have to wait for a new 1.21,9 fabric api to come out

It is already out. Please don't ask random unrelated questions on unrelated prs.

commented

@jeseibel would this PR make it possible to update Distant Horizons? #4906

commented

@HyperfocusArtisan
It looks like #4906 could potentially solve DH's problems, although I also noticed several of the events names where changed which feels a bit odd. If the events behave different then their older counterparts, then the name changes would make sense, although if they still function in a similar fashion to the old events I'd recommend keeping the names the same for better backwards compatibility.

For future reference Distant Horizons needs:

WorldRenderEvents.AFTER_SETUP
WorldRenderEvents.AFTER_ENTITIES
WorldRenderEvents.AFTER_TRANSLUCENT
commented

@HyperfocusArtisan It looks like #4906 could potentially solve DH's problems, although I also noticed several of the events names where changed which feels a bit odd. If the events behave different then their older counterparts, then the name changes would make sense, although if they still function in a similar fashion to the old events I'd recommend keeping the names the same for better backwards compatibility.

For future reference Distant Horizons needs:

WorldRenderEvents.AFTER_SETUP
WorldRenderEvents.AFTER_ENTITIES
WorldRenderEvents.AFTER_TRANSLUCENT

Please review/comment this on the pull request. There is no point in us merging something that is useless.

commented

#4906 has been merged, so I'm closing this as completed