Indigo applying diffuse shading twice on modded meshes

Question

Indigo applying diffuse shading twice on modded meshes

grondag opened this issue 4 years ago · 5 comments

grondag commented 4 years ago

All these blocks are white concrete. Note how the top face is fine.

I'll get a PR going.

modmuss50 · Answer 1 · 2020-05-24T15:54:41.000Z

I assume this is in 1.16?

grondag · Answer 2 · 2020-05-24T17:58:28.000Z

Yes, only affects 1.16. They moved the diffuse shading to chunk bake time or in GPU, which is what Indigo/Canvas want anyway so that it can be controlled. Noticed it during Canvas port. Should be an easy fix.

grondag · Answer 3 · 2020-05-24T17:59:56.000Z

What I think should be the fix took like two minutes. I'm spending my whole day updating all my crap to the latest snapshot to test it...

oliviathevampire · Answer 4 · 2020-05-25T09:50:20.000Z

finally! would you be able to fix a bug where the sides of doors are darker also?

grondag · Answer 5 · 2020-05-25T15:43:59.000Z

finally! would you be able to fix a bug where the sides of doors are darker also?

You should log defects you want to see fixed. Screenshots and steps to reproduce improve chance of fixing.

Share to