Fabric API

Fabric API

106M Downloads

Command API should use "RegistrationEnvrionment" instead of "dedicated" flag.

i509VCB opened this issue ยท 1 comments

commented

In a recent snapshot, the command manager now takes a 'RegistrationEnvironment' which is used to define how the server should define it's commands. There are 3 options, 'DEDICATED', 'INTEGRATED' and 'ALL'.

The 'ALL' option is only used in a data generator from what I see.

This breaks the previous assumption that commands can only ever be registered on a integrated or dedicated server since it is possible ALL may be passed in some context.

My solution to this does break the v1 command api, so we would need to advance to v2. This involves a new callback that specifies the RegistrationEnvironment as the second parameter instead of the dedicated flag.

However unlike fabric-commands-v0, this cannot easily be implemented in a backwards compatible fashion due to the registration environment possibly a quantum state where the flag is both true and false in the dedicated flag at the same time. So the v0/v1 and v2 registration systems would have to coexist.

commented

Closing since this seems like a non-issue to me right now.