Fabric API

Took a few hours to find the issue, but ive applied a work around, and pushing out 0.13.1 to all versions now.

Thanks for the speedy work as always :) you make this stuff look easy!

To elaborate, build 369 of Fabric API crashes the game when using 1.16 RC1 with fabric loader build 202. The key part of the log seems to be as follows:

org.spongepowered.asm.mixin.gen.throwables.InvalidAccessorException: No candidates were found matching sprites:Ljava/util/List; in net/minecraft/class_702$class_4090 for fabric-particles-v1.mixins.json:ParticleManagerAccessor$SimpleSpriteProviderAccessor->@Accessor[FIELD_GETTER]::getSprites()Ljava/util/List; [INJECT Applicator Phase -> fabric-particles-v1.mixins.json:ParticleManagerAccessor$SimpleSpriteProviderAccessor -> Apply Accessors ->  -> Locate -> fabric-particles-v1.mixins.json:ParticleManagerAccessor$SimpleSpriteProviderAccessor->@Accessor[FIELD_GETTER]::getSprites()Ljava/util/List;]
	at org.spongepowered.asm.mixin.gen.AccessorInfo.findTarget(AccessorInfo.java:518) ~[sponge-mixin-0.8+build.18.jar:0.8+build.18+unknown-b18.git-unknown]

A temporary workaround for the issue is to downgrade to build 367, which also supports RC1.

I don't think mixins remap when the class is referenced by a string

fabric/fabric-particles-v1/src/main/java/net/fabricmc/fabric/mixin/client/particle/ParticleManagerAccessor.java

Lines 46 to 50 in 3c9757a

    
           @Mixin(targets = "net/minecraft/client/particle/ParticleManager$SimpleSpriteProvider") 
        
           interface SimpleSpriteProviderAccessor { 
        
           	@Accessor("sprites") 
        
           	List<Sprite> getSprites(); 
        
           }

uhh

Crashes on 1.15.2 also https://paste.ee/p/erxPJ

Removed all the broken version as I dont have time to fix this right now.

The mixin looks valid, so it seems to be a mixin remapping bug somewhere. The question is where 🤔

	@Mixin(targets = "net/minecraft/client/particle/ParticleManager$SimpleSpriteProvider")
	interface SimpleSpriteProviderAccessor {
	@Accessor("sprites")
	List<Sprite> getSprites();
	}

Share to