Fabric API

Fabric API

106M Downloads

Ticking Entity Crash on Player in relation to keybinds

Geneticus opened this issue ยท 8 comments

commented

Submitting issue here per mod author request Log file is attached to the link. https://www.curseforge.com/minecraft/mc-mods/xaeros-world-map/issues/76

commented

Caused by: java.lang.NoSuchMethodError: net.fabricmc.fabric.mixin.client.keybinding.KeyCodeAccessor.getBoundKey()Lnet/minecraft/class_3675$class_306;

Looks like FabricMC/Mixin#28.

Also note to author to use this hook

public static InputUtil.Key getBoundKeyOf(KeyBinding keyBinding) {
instead of stuff in the mixin package in the future.

commented

It's hard to tell what's going on here because this mod is not visible source.

commented

@liach Thanks for the tip. Somehow missed that. Going to switch to it.
@Prospector I really doubt anything on my end will help. I was simply calling ((KeyCodeAccessor) keyBinding).getKeyCode() from PlayerEntity.tick(). Going to switch to KeyBindingHelper.getBoundKeyOf but it does the same thing.
EDIT: And I do make sure it's on the client side, btw, if it even matters.

commented

@thexaero is this fixed since this was merged ?

commented

@uiytt I haven't received any other crash reports like this, so probably. I don't know a way to reproduce this though.

commented

Well, can someone close this, and if someone get again this error on the new version, you can re-open this thread.

commented

don't think that's the related issue. it's that impl changed so mod using impl detail breaks.

commented

@liach This was before KeyCodeAccessor.getBoundKey() was renamed, if that's what you mean.